linux-kernel - Re: [PATCH 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Dec 2021 18:14:26 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Christian Lachner <gladiac@...il.com>
Cc:     perex@...ex.cz, tiwai@...e.com, kailang@...ltek.com,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ALSA: hda/realtek - Fix silent output on Gigabyte X570 Aorus Master after reboot from Windows

On Fri, 31 Dec 2021 11:21:38 +0100,
Christian Lachner wrote:
> 
> +static void alc1220_fixup_gb_x570(struct hda_codec *codec,
> +				     const struct hda_fixup *fix,
> +				     int action)
> +{
> +	static const hda_nid_t conn1[] = { 0x0c };
> +
> +	if (action != HDA_FIXUP_ACT_PRE_PROBE)
> +		return;
> +
> +	alc_write_coef_idx(codec, 0x1a, 0x01c1);
> +	alc_write_coef_idx(codec, 0x1b, 0x0202);
> +	alc_write_coef_idx(codec, 0x43, 0x3005);
> +	alc_write_coef_idx(codec, 0x58, 0x8fd6);
> +	alc_write_coef_idx(codec, 0x5f, 0xa3c5);
> +	alc_write_coef_idx(codec, 0x6a, 0x0232);

Those could be better with struct coef_fw table to be processed via
alc_process_coef_fw().

Also the coef update needs to be performed not only at PRE_INIT but
also at each resume, so this should be better done for action ==
HDA_FIXUP_ACT_INIT, I suppose.


thanks,

Takashi