lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202201010316.Xs1Xbwjo-lkp@intel.com>
Date:   Sat, 1 Jan 2022 03:40:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>
Subject: [dlemoal-libata:for-5.17-logging 46/79]
 include/linux/libata.h:1493:23: warning: format '%x' expects argument of
 type 'unsigned int', but argument 4 has type 'dma_addr_t' {aka 'long long
 unsigned int'}

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git for-5.17-logging
head:   fc730a4198504b83666da816eea7cb582fd9ae01
commit: 65625c4d468ec05a28451701b5808ea6400db5f5 [46/79] sata_fsl: convert VPRINTK() calls to ata_port_dbg()
config: powerpc64-randconfig-r036-20211231 (https://download.01.org/0day-ci/archive/20220101/202201010316.Xs1Xbwjo-lkp@intel.com/config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git/commit/?id=65625c4d468ec05a28451701b5808ea6400db5f5
        git remote add dlemoal-libata git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata.git
        git fetch --no-tags dlemoal-libata for-5.17-logging
        git checkout 65625c4d468ec05a28451701b5808ea6400db5f5
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash drivers/ata/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:559,
                    from include/linux/kernel.h:20,
                    from drivers/ata/sata_fsl.c:13:
   drivers/ata/sata_fsl.c: In function 'fsl_sata_set_irq_coalescing':
   drivers/ata/sata_fsl.c:316:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
     316 |         dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
         |                 ^~~~~~~~~~
         |                 |
         |                 struct device **
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
     155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:316:9: note: in expansion of macro 'dev_dbg'
     316 |         dev_dbg(&host->dev, "interrupt coalescing, count = 0x%x, ticks = %x\n",
         |         ^~~~~~~
   include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
      73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
         |                                                    ~~~~~~~~~~~~~~~~~~~~~^~~
   drivers/ata/sata_fsl.c:318:17: error: passing argument 2 of '__dynamic_dev_dbg' from incompatible pointer type [-Werror=incompatible-pointer-types]
     318 |         dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
         |                 ^~~~~~~~~~
         |                 |
         |                 struct device **
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
     155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
     318 |         dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
         |         ^~~~~~~
   include/linux/dynamic_debug.h:73:73: note: expected 'const struct device *' but argument is of type 'struct device **'
      73 | void __dynamic_dev_dbg(struct _ddebug *descriptor, const struct device *dev,
         |                                                    ~~~~~~~~~~~~~~~~~~~~~^~~
   drivers/ata/sata_fsl.c:318:29: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'void *' [-Wformat=]
     318 |         dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
         |                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
     155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:155:30: note: in expansion of macro 'dev_fmt'
     155 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/ata/sata_fsl.c:318:9: note: in expansion of macro 'dev_dbg'
     318 |         dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
         |         ^~~~~~~
   drivers/ata/sata_fsl.c:318:65: note: format string is defined here
     318 |         dev_dbg(&host->dev, "ICC register status: (hcr base: 0x%x) = 0x%x\n",
         |                                                                ~^
         |                                                                 |
         |                                                                 unsigned int
         |                                                                %p
   In file included from include/linux/kernel.h:20,
                    from drivers/ata/sata_fsl.c:13:
   drivers/ata/sata_fsl.c: In function 'sata_fsl_port_start':
>> include/linux/libata.h:1493:23: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
    1493 |         pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
         |                       ^~~~~~~~~
   include/linux/printk.h:340:21: note: in definition of macro 'pr_fmt'
     340 | #define pr_fmt(fmt) fmt
         |                     ^~~
   include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call'
     152 |         __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
     162 |         _dynamic_func_call(fmt, __dynamic_pr_debug,             \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
     574 |         dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~
   include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
    1493 |         pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
         |         ^~~
   include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
    1504 |         ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:734:9: note: in expansion of macro 'ata_port_dbg'
     734 |         ata_port_dbg(ap, "CHBA = 0x%x, cmdentry_phys = 0x%x\n",
         |         ^~~~~~~~~~~~
   include/linux/libata.h:1493:23: warning: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'dma_addr_t' {aka 'long long unsigned int'} [-Wformat=]
    1493 |         pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
         |                       ^~~~~~~~~
   include/linux/printk.h:340:21: note: in definition of macro 'pr_fmt'
     340 | #define pr_fmt(fmt) fmt
         |                     ^~~
   include/linux/dynamic_debug.h:152:9: note: in expansion of macro '__dynamic_func_call'
     152 |         __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
     162 |         _dynamic_func_call(fmt, __dynamic_pr_debug,             \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
     574 |         dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~
   include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
    1493 |         pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
         |         ^~~
   include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
    1504 |         ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:734:9: note: in expansion of macro 'ata_port_dbg'
     734 |         ata_port_dbg(ap, "CHBA = 0x%x, cmdentry_phys = 0x%x\n",
         |         ^~~~~~~~~~~~
   In file included from include/linux/printk.h:559,
                    from include/linux/kernel.h:20,
                    from drivers/ata/sata_fsl.c:13:
   drivers/ata/sata_fsl.c: In function 'sata_fsl_init_controller':
   drivers/ata/sata_fsl.c:1345:22: error: 'ap' undeclared (first use in this function); did you mean 'up'?
    1345 |         ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
         |                      ^~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
     162 |         _dynamic_func_call(fmt, __dynamic_pr_debug,             \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
     574 |         dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~
   include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
    1493 |         pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
         |         ^~~
   include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
    1504 |         ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:1345:9: note: in expansion of macro 'ata_port_dbg'
    1345 |         ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
         |         ^~~~~~~~~~~~
   drivers/ata/sata_fsl.c:1345:22: note: each undeclared identifier is reported only once for each function it appears in
    1345 |         ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
         |                      ^~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:162:9: note: in expansion of macro '_dynamic_func_call'
     162 |         _dynamic_func_call(fmt, __dynamic_pr_debug,             \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/printk.h:574:9: note: in expansion of macro 'dynamic_pr_debug'
     574 |         dynamic_pr_debug(fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~~
   include/linux/libata.h:1493:9: note: in expansion of macro 'pr_debug'
    1493 |         pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
         |         ^~~
   include/linux/libata.h:1504:9: note: in expansion of macro 'ata_port_printk'
    1504 |         ata_port_printk(debug, ap, fmt, ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:1345:9: note: in expansion of macro 'ata_port_dbg'
    1345 |         ata_port_dbg(ap, "icc = 0x%x\n", ioread32(hcr_base + ICC));
         |         ^~~~~~~~~~~~
   drivers/ata/sata_fsl.c: At top level:
   drivers/ata/sata_fsl.c:1383:22: warning: initialized field overwritten [-Woverride-init]
    1383 |         .can_queue = SATA_FSL_QUEUE_DEPTH,
         |                      ^~~~~~~~~~~~~~~~~~~~
   drivers/ata/sata_fsl.c:1383:22: note: (near initialization for 'sata_fsl_sht.can_queue')
   In file included from include/linux/printk.h:559,
                    from include/linux/kernel.h:20,


vim +1493 include/linux/libata.h

071f44b1d2c051 Tejun Heo       2008-04-07  1491  
c6cf72be22beb4 Hannes Reinecke 2021-12-21  1492  #define ata_port_printk(level, ap, fmt, ...)			\
c6cf72be22beb4 Hannes Reinecke 2021-12-21 @1493  	pr_ ## level ("ata%u: " fmt, (ap)->print_id, ##__VA_ARGS__)
a9a79dfec23956 Joe Perches     2011-04-15  1494  

:::::: The code at line 1493 was first introduced by commit
:::::: c6cf72be22beb4f0dfeedcf34ffc0926b2df61b5 libata: move ata_{port,link,dev}_dbg to standard pr_XXX() macros

:::::: TO: Hannes Reinecke <hare@...e.de>
:::::: CC: Damien Le Moal <damien.lemoal@...nsource.wdc.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ