linux-kernel - Re: [PATCH] mctp: Remove only static neighbour on RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e20e47833649b5141fa327aa8113e34d4b1bbe15.camel@codeconstruct.com.au>
Date:   Fri, 31 Dec 2021 11:33:00 +0800
From:   Jeremy Kerr <jk@...econstruct.com.au>
To:     Jakub Kicinski <kuba@...nel.org>,
        Gagan Kumar <gagan1kumar.cs@...il.com>
Cc:     matt@...econstruct.com.au, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mctp: Remove only static neighbour on RTM_DELNEIGH

Hi Jakub & Gagan,

> > Add neighbour source flag in mctp_neigh_remove(...) to allow
> > removal of only static neighbours.
> 
> Which are the only ones that exist today right?

That's correct. There may be a future facility for the kernel to perform
neighbour discovery itself (somewhat analogous to ARP), but only the
static entries are possible at the moment.

> Can you clarify the motivation and practical impact of the change 
> in the commit message to make it clear? AFAICT this is a no-op / prep
> for some later changes, right Jeremy?

Yes, it'll be a no-op now; I'm not aware of any changes coming that
require parameterisation of the neighbour type yet.

Gagan - can you provide any context on this change?

Cheers,

Jeremy