linux-kernel - Re: [PATCH] input: appletouch: initialize work before device registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yc6PUmjd4BDctN9h@google.com>
Date:   Thu, 30 Dec 2021 21:04:18 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     kernel@....de, mjg59@...f.ucam.org, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        syzbot+b88c5eae27386b252bbd@...kaller.appspotmail.com
Subject: Re: [PATCH] input: appletouch: initialize work before device
 registration

On Thu, Dec 30, 2021 at 05:11:51PM +0300, Pavel Skripkin wrote:
> Syzbot has reported warning in __flush_work(). This warning is caused by
> work->func == NULL, which means missing work initialization.
> 
> This may happen, since input_dev->close() calls cancel_work_sync(&dev->work),
> but dev->work initalization happens _after_ input_register_device()
> call.
> 
> So this patch moves dev->work initialization before registering input
> device
> 
> Fixes: 5a6eb676d3bc ("Input: appletouch - improve powersaving for Geyser3 devices")
> Reported-and-tested-by: syzbot+b88c5eae27386b252bbd@...kaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>

Applied, thank you.

-- 
Dmitry