linux-kernel - Re: [PATCH] random: use IS_ENABLED(CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yc6+1YFsxLVHG/WW@owl.dominikbrodowski.net>
Date:   Fri, 31 Dec 2021 09:27:01 +0100
From:   Dominik Brodowski <linux@...inikbrodowski.net>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] random: use IS_ENABLED(CONFIG_NUMA) instead of ifdefs

Am Thu, Dec 30, 2021 at 04:14:10PM +0100 schrieb Jason A. Donenfeld:
> Rather than an awkward combination of ifdefs and __maybe_unused, we can
> ensure more source gets parsed, regardless of the configuration, by
> using IS_ENABLED for the CONFIG_NUMA conditional code. This makes things
> cleaner and easier to follow.
> 
> I've confirmed that on !CONFIG_NUMA, we don't wind up with excess code
> by accident; the generated object file is the same.
> 
> Signed-off-by: Jason A. Donenfeld <Jason@...c4.com>

Reviewed-by: Dominik Brodowski <linux@...inikbrodowski.net>

Thanks,
	Dominik