linux-kernel - Re: [PATCH v2 6/7] staging: r8188eu: IntArray and C2hArray are set but never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49705204-bfce-d28d-fedb-bc07aeb57fc6@stud.uni-goettingen.de>
Date:   Sat, 1 Jan 2022 09:32:45 +0100
From:   Michael Straube <michael.straube@...d.uni-goettingen.de>
To:     <gregkh@...uxfoundation.org>
CC:     <Larry.Finger@...inger.net>, <phil@...lpotter.co.uk>,
        <linux-staging@...ts.linux.dev>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 6/7] staging: r8188eu: IntArray and C2hArray are set
 but never used

On 1/1/22 09:17, Michael Straube wrote:
> The fields IntArray and C2hArray of struct hal_data_8188e are set but
> never used. Remove them and remove interrupt_handler_8188eu() since it
> does nothing now.
> 
> While at it, remove the unsed defines USB_INTR_CONTENT_CPWM1_OFFSET
> and USB_INTR_CONTENT_CPWM2_OFFSET as well.
> 
> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> v2: Remove interrupt_handler_8188eu() since it does nothing now.
> 
>   drivers/staging/r8188eu/hal/usb_ops_linux.c   | 20 -------------------
>   .../staging/r8188eu/include/rtl8188e_hal.h    |  3 ---
>   .../staging/r8188eu/include/rtl8188e_spec.h   |  7 -------
>   3 files changed, 30 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> index 9ec55a77dccd..4a0ab4053e90 100644
> --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c
> +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c
> @@ -183,24 +183,6 @@ int rtw_writeN(struct adapter *adapter, u32 addr, u32 length, u8 *data)
>   	return RTW_STATUS_CODE(ret);
>   }
>   
> -static void interrupt_handler_8188eu(struct adapter *adapt, u16 pkt_len, u8 *pbuf)
> -{
> -	struct hal_data_8188e *haldata = &adapt->haldata;
> -
> -	if (pkt_len != INTERRUPT_MSG_FORMAT_LEN) {
> -		DBG_88E("%s Invalid interrupt content length (%d)!\n", __func__, pkt_len);
> -		return;
> -	}

I just noticed that INTERRUPT_MSG_FORMAT_LEN can be removed from
rtl8188e_recv.h now too. I'll send v3 soon.

Sorry,
Michael