linux-kernel - Re: [PATCH v3 5/7] staging: r8188eu: remove unused fields from struct hal_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jan 2022 18:23:59 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] staging: r8188eu: remove unused fields from
 struct hal_data_8188e

Thus wrote Michael Straube (straube.linux@...il.com):

> Remove unused fields from struct hal_data_8188e.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> v3: no changes
> v2: no changes

>  .../staging/r8188eu/include/rtl8188e_hal.h    | 30 -------------------
>  1 file changed, 30 deletions(-)

> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 40b3db34b8f2..2ce42d647a34 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -175,15 +175,9 @@ struct hal_data_8188e {

>  	u16	BasicRateSet;

> -	/*  EEPROM setting. */
> -	u16	EEPROMSVID;
> -	u16	EEPROMSDID;
>  	u8	EEPROMRegulatory;
> -
>  	u8	EEPROMThermalMeter;

> -	bool	EepromOrEfuse;
> -
>  	u8	Index24G_CCK_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
>  	u8	Index24G_BW40_Base[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
>  	/* If only one tx, only BW20 and OFDM are used. */
> @@ -192,11 +186,6 @@ struct hal_data_8188e {
>  	s8	BW20_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT];
>  	s8	BW40_24G_Diff[RF_PATH_MAX][MAX_TX_COUNT];

> -	u8	TxPwrLevelCck[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> -	/*  For HT 40MHZ pwr */
> -	u8	TxPwrLevelHT40_1S[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
> -	/*  For HT 40MHZ pwr */
> -	u8	TxPwrLevelHT40_2S[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
>  	/*  HT 20<->40 Pwr diff */
>  	u8	TxPwrHt20Diff[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
>  	/*  For HT<->legacy pwr diff */
> @@ -205,7 +194,6 @@ struct hal_data_8188e {
>  	u8	PwrGroupHT20[RF_PATH_MAX][CHANNEL_MAX_NUMBER];
>  	u8	PwrGroupHT40[RF_PATH_MAX][CHANNEL_MAX_NUMBER];

> -	u8	LegacyHTTxPowerDiff;/*  Legacy to HT rate power diff */
>  	/*  The current Tx Power Level */
>  	u8	CurrentCckTxPwrIdx;
>  	u8	CurrentOfdm24GTxPwrIdx;
> @@ -213,21 +201,12 @@ struct hal_data_8188e {
>  	u8	CurrentBW4024GTxPwrIdx;

>  	/*  Read/write are allow for following hardware information variables */
> -	u8	framesync;
> -	u32	framesyncC34;
> -	u8	framesyncMonitor;
> -	u8	DefaultInitialGain[4];
>  	u8	pwrGroupCnt;
>  	u32	MCSTxPowerLevelOriginalOffset[MAX_PG_GROUP][16];
> -	u32	CCKTxPowerLevelOriginalOffset;

>  	u8	CrystalCap;
> -	u32	AntennaTxPath;			/*  Antenna path Tx */
> -	u32	AntennaRxPath;			/*  Antenna path Rx */
>  	u8	ExternalPA;

> -	u8	b1x1RecvCombine;	/*  for 1T1R receive combining */
> -
>  	u32	AcParam_BE; /* Original parameter for BE, use for EDCA turbo. */

>  	struct bb_reg_def PHYRegDef[2];	/* Radio A/B */
> @@ -254,17 +233,9 @@ struct hal_data_8188e {
>  	u8	FwRsvdPageStartOffset; /* Reserve page start offset except
>  					*  beacon in TxQ. */

> -	/*  2010/08/09 MH Add CU power down mode. */
> -	bool		pwrdown;
> -
>  	u8	OutEpQueueSel;
>  	u8	OutEpNumber;

> -	/*  2010/11/22 MH Add for slim combo debug mode selective. */
> -	/*  This is used for fix the drawback of CU TSMC-A/UMC-A cut.
> -	 * HW auto suspend ability. Close BT clock. */
> -	bool		SlimComboDbg;
> -
>  	u16	EfuseUsedBytes;

>  	struct P2P_PS_Offload_t	p2p_ps_offload;
> @@ -280,7 +251,6 @@ struct hal_data_8188e {
>  	u8	C2hArray[16];
>  	u8	UsbTxAggMode;
>  	u8	UsbTxAggDescNum;
> -	u32	MaxUsbRxAggBlock;

>  	enum usb_rx_agg_mode UsbRxAggMode;
>  	u8	UsbRxAggBlockCount;	/*  USB Block count. Block size is
> -- 
> 2.34.1

Acked-by: Martin Kaiser <martin@...ser.cx>