linux-kernel - Re: [PATCH v3 7/7] staging: r8188eu: FwRsvdPageStartOffset is set but never used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 2 Jan 2022 18:28:11 +0100
From:   Martin Kaiser <martin@...ser.cx>
To:     Michael Straube <straube.linux@...il.com>
Cc:     gregkh@...uxfoundation.org, Larry.Finger@...inger.net,
        phil@...lpotter.co.uk, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/7] staging: r8188eu: FwRsvdPageStartOffset is set
 but never used

Thus wrote Michael Straube (straube.linux@...il.com):

> The field FwRsvdPageStartOffset of struct hal_data_8188e is set but
> never used. Remove it.

> Signed-off-by: Michael Straube <straube.linux@...il.com>
> ---
> v3: no changes
> v2: no changes

>  drivers/staging/r8188eu/hal/rtl8188e_cmd.c     | 3 ---
>  drivers/staging/r8188eu/include/rtl8188e_hal.h | 2 --
>  2 files changed, 5 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c
> index ca24e17c369d..a491c37777df 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_cmd.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_cmd.c
> @@ -440,7 +440,6 @@ void CheckFwRsvdPageContent(struct adapter *Adapter)
>  /*  2009.10.15 by tynli. */
>  static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
>  {
> -	struct hal_data_8188e *haldata;
>  	struct xmit_frame	*pmgntframe;
>  	struct pkt_attrib	*pattrib;
>  	struct xmit_priv *pxmitpriv;
> @@ -461,7 +460,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
>  		return;
>  	}

> -	haldata = &adapt->haldata;
>  	pxmitpriv = &adapt->xmitpriv;
>  	pmlmeext = &adapt->mlmeextpriv;
>  	pmlmeinfo = &pmlmeext->mlmext_info;
> @@ -480,7 +478,6 @@ static void SetFwRsvdPagePkt(struct adapter *adapt, bool bDLFinished)
>  	if (PageNeed == 1)
>  		PageNeed += 1;
>  	PageNum += PageNeed;
> -	haldata->FwRsvdPageStartOffset = PageNum;

>  	BufIndex += PageNeed * 128;

> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 239d0db55639..25f3c04e81b7 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -230,8 +230,6 @@ struct hal_data_8188e {

>  	u8	bDumpRxPkt;/* for debug */
>  	u8	bDumpTxPkt;/* for debug */
> -	u8	FwRsvdPageStartOffset; /* Reserve page start offset except
> -					*  beacon in TxQ. */

>  	u8	OutEpQueueSel;
>  	u8	OutEpNumber;
> -- 
> 2.34.1

Acked-by: Martin Kaiser <martin@...ser.cx>