linux-kernel - Re: [PATCH rdma-rc] RDMA/mlx5: Fix dereg mr flow for kernel MRs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdLHDzmNXlqSMj/A@unreal>
Date:   Mon, 3 Jan 2022 11:51:11 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Tony Lu <tonylu@...ux.alibaba.com>
Cc:     Jason Gunthorpe <jgg@...dia.com>, Maor Gottlieb <maorg@...dia.com>,
        Alaa Hleihel <alaa@...dia.com>,
        Chuck Lever <chuck.lever@...cle.com>,
        linux-kernel@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH rdma-rc] RDMA/mlx5: Fix dereg mr flow for kernel MRs

On Wed, Dec 22, 2021 at 10:51:58AM +0800, Tony Lu wrote:
> On Tue, Dec 21, 2021 at 11:46:41AM +0200, Leon Romanovsky wrote:
> > From: Maor Gottlieb <maorg@...dia.com>
> > 
> > The cited commit moved umem into the union, hence
> > umem could be accessed only for user MRs. Add udata check
> > before access umem in the dereg flow.
> > 
> > Fixes: f0ae4afe3d35 ("RDMA/mlx5: Fix releasing unallocated memory in dereg MR flow")
> > Tested-by: Chuck Lever <chuck.lever@...cle.com>
> > Signed-off-by: Maor Gottlieb <maorg@...dia.com>
> > Signed-off-by: Leon Romanovsky <leonro@...dia.com>
> > ---
> >  drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +-
> >  drivers/infiniband/hw/mlx5/mr.c      | 4 ++--
> >  drivers/infiniband/hw/mlx5/odp.c     | 4 ++--
> >  3 files changed, 5 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h b/drivers/infiniband/hw/mlx5/mlx5_ib.h
> 
> This patch was tested and works for me in our environment for SMC. It
> wouldn't panic when release link and call ib_dereg_mr.
> 
> Tested-by: Tony Lu <tonylu@...ux.alibaba.com>

Thanks, unfortunately, this patch is incomplete.

> 
> Thanks,
> Tony Lu