linux-kernel - Re: [PATCH] Input: gpio-keys: Avoid clearing twice some memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <H4T45R.07J01GT7EIY23@crapouillou.net>
Date:   Mon, 03 Jan 2022 11:26:41 +0000
From:   Paul Cercueil <paul@...pouillou.net>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     dmitry.torokhov@...il.com, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] Input: gpio-keys: Avoid clearing twice some memory

Hi,

Le mer., déc. 29 2021 at 22:26:56 +0100, Christophe JAILLET 
<christophe.jaillet@...adoo.fr> a écrit :
> bitmap_parselist() already clears the 'bits' bitmap, so there is no 
> need
> to clear it when it is allocated. This just wastes some cycles.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Cheers,
-Paul

> ---
>  drivers/input/keyboard/gpio_keys.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/keyboard/gpio_keys.c 
> b/drivers/input/keyboard/gpio_keys.c
> index 8dbf1e69c90a..d75a8b179a8a 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -247,7 +247,7 @@ static ssize_t gpio_keys_attr_store_helper(struct 
> gpio_keys_drvdata *ddata,
>  	ssize_t error;
>  	int i;
> 
> -	bits = bitmap_zalloc(n_events, GFP_KERNEL);
> +	bits = bitmap_alloc(n_events, GFP_KERNEL);
>  	if (!bits)
>  		return -ENOMEM;
> 
> --
> 2.32.0
>