| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 3 Jan 2022 12:56:17 +0800
From: Xiangyu Chen <xiangyu.chen@....com>
To: grygorii.strashko@...com, davem@...emloft.net, kuba@...nel.org,
linux-omap@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: xiangyu.chen@....com, Xiangyu Chen <xiangyu.chen@....com>
Subject: [PATCH 1/2] net: ethernet: ti: cpsw-phy-sel: add support slave interface using internal clock in dual rmii emac mode
Dear Maintainer,
Firstly, happy new year.
This patch regarding to add a way to setup/config the TI-AM335x series
Soc for 2 ways phy clock mode under RMII mode.
The basic scenario is when we have 2 PHYs connected to AM335x in RMII
mode, either we set the both of phy in external clock mode or we set the phy in internal
clock mode.
As TI suggetsion, when under RMII mode, the clock should use an external
osc due to AM335x cannot generate a low-jitter stable 50MHz clock, this
might cause some PHY cannot work correctly. But in some case (e.g. our
design, no impact on using low speed PHY for debugging/management).
There is no impact on some model phys.
So I think we should provide a way to allow user can set/config the PHY
chose clock mode in dual RMII emac mode.
Tests:
Below is my testing environment:
am335x SOC --RMII 1--> PHY1 (eth0) which using internal clock
|-RMII 2--> PHY2 (eth1) which using external clock
Booting log:
Booting log:
[ 1.843108] cpsw 4a100000.ethernet: Detected MACID = 78:04:73:37:68:6c
[ 1.850924] cpsw 4a100000.ethernet: initialized cpsw ale version 1.4
[ 1.857842] cpsw 4a100000.ethernet: ALE Table size 1024
[ 1.863449] cpsw 4a100000.ethernet: cpts: overflow check period 500 (jiffies)
[ 1.874620] cpsw 4a100000.ethernet: cpsw: Detected MACID = 78:04:73:37:68:6e
[ 4.017695] net eth0: initializing cpsw version 1.12 (0)
[ 5.207867] cpsw 4a100000.ethernet eth0: Link is Up - 10Mbps/Full - flow control off
[ 29.747480] net eth1: initializing cpsw version 1.12 (0)
[ 30.806444] cpsw 4a100000.ethernet eth1: Link is Up - 100Mbps/Full - flow control off
# ifconfig
eth0 Link encap:Ethernet HWaddr 00:FA:F9:00:61:88
inet addr:192.168.0.20 Bcast:192.168.0.255 Mask:255.255.255.0
inet6 addr: fe80::2fa:f9ff:fe00:6188/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:20 errors:0 dropped:0 overruns:0 frame:0
TX packets:35 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:1394 (1.3 KiB) TX bytes:3272 (3.1 KiB)
Interrupt:50
eth1 Link encap:Ethernet HWaddr 78:04:73:37:68:6E
inet addr:10.176.28.165 Bcast:10.176.29.255 Mask:255.255.254.0
inet6 addr: fe80::7a04:73ff:fe37:686e/64 Scope:Link
UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1
RX packets:1809 errors:0 dropped:0 overruns:0 frame:0
TX packets:99 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:123057 (120.1 KiB) TX bytes:9012 (8.8 KiB)
lo Link encap:Local Loopback
inet addr:127.0.0.1 Mask:255.0.0.0
inet6 addr: ::1/128 Scope:Host
UP LOOPBACK RUNNING MTU:65536 Metric:1
RX packets:44 errors:0 dropped:0 overruns:0 frame:0
TX packets:44 errors:0 dropped:0 overruns:0 carrier:0
collisions:0 txqueuelen:1000
RX bytes:4872 (4.7 KiB) TX bytes:4872 (4.7 KiB)
PHY1 (eth0, using internal clock from AM335x) ping:
#ping 192.168.0.20
PING 192.168.0.20 (192.168.0.20): 56 data bytes
64 bytes from 192.168.0.20: seq=0 ttl=64 time=1.340 ms
^C
--- 192.168.0.20 ping statistics ---
1 packets transmitted, 1 packets received, 0% packet loss
round-trip min/avg/max = 1.340/1.340/1.340 ms
PHY2 (eth1, using external clock to AM335x) ping:
# ping 10.176.28.1
PING 10.176.28.1 (10.176.28.1): 56 data bytes
64 bytes from 10.176.28.1: seq=1 ttl=254 time=1.967 ms
64 bytes from 10.176.28.1: seq=2 ttl=254 time=1.652 ms
64 bytes from 10.176.28.1: seq=3 ttl=254 time=1.688 ms
^C
--- 10.176.28.1 ping statistics ---
Both phy working normally.
Thanks and Best regrads,
Xiangyu
>From 6c7220aca37176df0ea46846b0f5c6e68d73aca0 Mon Sep 17 00:00:00 2001
From: Xiangyu Chen <xiangyu.chen@....com>
Date: Fri, 31 Dec 2021 10:28:14 +0800
Subject: [PATCH 1/2] net: ethernet: ti: cpsw-phy-sel: add support slave
interface using internal clock in dual rmii emac mode
The am335x support dual emac in rmii mode, the rmii clock
can be provided by external osc or internal soc by ref_clk pin.
When rmii-clock-ext has been set in device tree, both emac
has been set to external clock mode, otherwise both emac has
been set to internal clock mode.
In some case, one slave can be used external clock, another
slave can be used internal clock.
This commit to support define a method to tell driver which
slave phy use internal clock when the "rmii-clock-ext" has
been set.
Signed-off-by: Xiangyu Chen <xiangyu.chen@....com>
---
drivers/net/ethernet/ti/cpsw-phy-sel.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ti/cpsw-phy-sel.c b/drivers/net/ethernet/ti/cpsw-phy-sel.c
index e8f38e3f7..332d8e018 100644
--- a/drivers/net/ethernet/ti/cpsw-phy-sel.c
+++ b/drivers/net/ethernet/ti/cpsw-phy-sel.c
@@ -30,6 +30,7 @@
struct cpsw_phy_sel_priv {
struct device *dev;
+ u32 ignore_slave;
u32 __iomem *gmii_sel;
bool rmii_clock_external;
void (*cpsw_phy_sel)(struct cpsw_phy_sel_priv *priv,
@@ -78,10 +79,13 @@ static void cpsw_gmii_sel_am3352(struct cpsw_phy_sel_priv *priv,
mode <<= slave * 2;
if (priv->rmii_clock_external) {
- if (slave == 0)
- mode |= AM33XX_GMII_SEL_RMII1_IO_CLK_EN;
- else
- mode |= AM33XX_GMII_SEL_RMII2_IO_CLK_EN;
+ if (slave == 0) {
+ if (priv->ignore_slave != slave)
+ mode |= AM33XX_GMII_SEL_RMII1_IO_CLK_EN;
+ } else {
+ if (priv->ignore_slave != slave)
+ mode |= AM33XX_GMII_SEL_RMII2_IO_CLK_EN;
+ }
}
if (rgmii_id) {
@@ -221,6 +225,7 @@ static int cpsw_phy_sel_probe(struct platform_device *pdev)
priv->dev = &pdev->dev;
priv->cpsw_phy_sel = of_id->data;
+ priv->ignore_slave = 0xff;
priv->gmii_sel = devm_platform_ioremap_resource_byname(pdev, "gmii-sel");
if (IS_ERR(priv->gmii_sel))
@@ -229,6 +234,8 @@ static int cpsw_phy_sel_probe(struct platform_device *pdev)
if (of_find_property(pdev->dev.of_node, "rmii-clock-ext", NULL))
priv->rmii_clock_external = true;
+ of_property_read_u32(pdev->dev.of_node, "ignore-slave", &priv->ignore_slave);
+
dev_set_drvdata(&pdev->dev, priv);
return 0;
--
2.25.1
Powered by blists - more mailing lists