linux-kernel - Re: Reference to non-existing config LOGIC_IOMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f86494dfec02e41e6897e8a9617d66b2d7674698.camel@sipsolutions.net>
Date:   Mon, 03 Jan 2022 16:36:54 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>,
        Richard Weinberger <richard@....at>,
        Arnd Bergmann <arnd@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Reference to non-existing config LOGIC_IOMEM_FALLBACK

On Thu, 2021-12-30 at 12:45 +0000, Lukas Bulwahn wrote:
> Dear Johannes, dear Richard,
> 
> In commit ca2e334232b6 ("lib: add iomem emulation (logic_iomem)"), you
> have added an ifdef on the non-existing config LOGIC_IOMEM_FALLBACK in
> ./lib/logic_iomem.c.
> 
> In the commit message, you note:
> 
>     To use, an architecture must 'select LOGIC_IOMEM' in Kconfig
>     and then include <asm-generic/logic_io.h> into asm/io.h to get
>     the __raw_read*/__raw_write* functions.
> 
>     Optionally, an architecture may 'select LOGIC_IOMEM_FALLBACK'
>     in which case non-emulated regions will 'fall back' to the
>     various real_* functions that must then be provided.
> 
> This config LOGIC_IOMEM and config LOGIC_IOMEM_FALLBACK is however not
> defined in any Kconfig file in the current repository.

Yeah, umm. Artifact of renaming things ...

> Did you mean that the architecture shall select INDIRECT_IOMEM and
> INDIRECT_IOMEM_FALLBACK, which were defined in your commit, and the
> questionable ifdef in ./lib/logic_iomem.c needs to be changed to
> INDIRECT_IOMEM_FALLBACK?

Yes. I'll send a fix, thanks for reporting.

johannes