linux-kernel - Re: [PATCH] random: Don't reset crng_init_cnt on urandom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHmME9otnT=XeMPGYW5H8TOu9aLxxKi6_gT-Fnvh5Jy+WM-HGA@mail.gmail.com>
Date:   Mon, 3 Jan 2022 17:03:57 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Jann Horn <jannh@...gle.com>
Cc:     "Theodore Ts'o" <tytso@....edu>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] random: Don't reset crng_init_cnt on urandom_read()

On Mon, Jan 3, 2022 at 4:59 PM Jann Horn <jannh@...gle.com> wrote:
> This code was inconsistent, and it probably made things worse - just get
> rid of it.

Rather than adding crng_init_cnt=0 if crng_init<1 to extract_crng_user
and get_random_bytes, getting rid of it like this seems probably okay
and makes the model simpler. I'll apply this. Thank you.

Jason