linux-kernel - Re: [PATCH] i3c/master/mipi-i3c-hci: correct the config reference for endianness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3p9691n5-3qs-7s3q-pp9-389621935prr@onlyvoer.pbz>
Date:   Mon, 3 Jan 2022 12:03:18 -0500 (EST)
From:   Nicolas Pitre <npitre@...libre.com>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
cc:     Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-i3c@...ts.infradead.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i3c/master/mipi-i3c-hci: correct the config reference
 for endianness

On Mon, 3 Jan 2022, Lukas Bulwahn wrote:

> The referred config BIG_ENDIAN does not exist. The config for the
> endianness of the CPU architecture is called CPU_BIG_ENDIAN.
> 
> Correct the config name to the existing config for the endianness.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Acked-by: Nicolas Pitre <npitre@...libre.com>

> ---
>  drivers/i3c/master/mipi-i3c-hci/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 1b73647cc3b1..8c01123dc4ed 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -662,7 +662,7 @@ static int i3c_hci_init(struct i3c_hci *hci)
>  
>  	/* Make sure our data ordering fits the host's */
>  	regval = reg_read(HC_CONTROL);
> -	if (IS_ENABLED(CONFIG_BIG_ENDIAN)) {
> +	if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN)) {
>  		if (!(regval & HC_CONTROL_DATA_BIG_ENDIAN)) {
>  			regval |= HC_CONTROL_DATA_BIG_ENDIAN;
>  			reg_write(HC_CONTROL, regval);
> -- 
> 2.17.1
> 
>