Message-ID: <ca8e8e62d4c7d9b714c64fbf9e59ba0ebe42bea4.camel@mediatek.com>
Date:   Mon, 3 Jan 2022 15:43:28 +0800
From:   Roger Lu <roger.lu@...iatek.com>
To:     Matthias Brugger <matthias.bgg@...il.com>,
        Enric Balletbo Serra <eballetbo@...il.com>,
        Kevin Hilman <khilman@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Nicolas Boichat <drinkcat@...gle.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     Fan Chen <fan.chen@...iatek.com>,
        HenryC Chen <HenryC.Chen@...iatek.com>,
        YT Lee <yt.lee@...iatek.com>,
        Xiaoqing Liu <Xiaoqing.Liu@...iatek.com>,
        Charles Yang <Charles.Yang@...iatek.com>,
        Angus Lin <Angus.Lin@...iatek.com>,
        Mark Rutland <mark.rutland@....com>,
        Nishanth Menon <nm@...com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-pm@...r.kernel.org>,
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v16 0/7] soc: mediatek: SVS: introduce MTK SVS

Hi Matthias,

On Thu, 2021-12-30 at 14:18 +0100, Matthias Brugger wrote:
> 
> On 28/04/2021 08:54, Roger Lu wrote:
> > 1. SVS driver uses OPP adjust event in [1] to update OPP table voltage part.
> > 2. SVS driver gets thermal/GPU device by node [2][3] and CPU device by
> > get_cpu_device().
> > After retrieving subsys device, SVS driver calls device_link_add() to make
> > sure probe/suspend callback priority.
> > 3. SVS dts refers to reset controller [4] to help reset SVS HW.
> > 
> > #mt8183 SVS related patches
> > [1] 
> > https://urldefense.com/v3/__https://patchwork.kernel.org/patch/11193513/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MIscKXW-$
> >  
> 
> Already mainline, please either refer to the commit, to make it clear it's 
> maineline or drop it.
> 
> > [2] 
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20201013102358.22588-2-michael.kao@mediatek.com/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3ML35Ale5$
> >  
> 
> Same here.
> 
> > [3] 
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20200306041345.259332-3-drinkcat@chromium.org/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MMUMr7Oh$
> >  
> 
> Same here,

Thanks for the review. I'll refer to mainline or the latest reviewing patch. 

> 
> > 
> > #mt8192 SVS related patches
> > [1] 
> > https://urldefense.com/v3/__https://patchwork.kernel.org/patch/11193513/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MIscKXW-$
> >  
> 
> Same here, it's actually the same link as [1].
> 
> > [2] 
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20201223074944.2061-1-michael.kao@mediatek.com/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MEUxFEDM$
> >  
> > [3] 
> > https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1360551/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MNObUeLt$
> >  
> > [4] 
> > https://urldefense.com/v3/__https://patchwork.kernel.org/project/linux-mediatek/patch/20200817030324.5690-5-crystal.guo@mediatek.com/__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MMx-JKoe$
> >  
> 
> There are many dependencies for that. Some patches need resubmit, others seem
> to 
> be stale. I'd advise to concentrate on mt8183 for now and add support for
> mt8192 
> once dependencies have settled.

Sure, let's concentrate on mt8183 patches first. Thanks for sharing the advice.

> 
> Regards,
> Matthias
> 
> > 
> > changes since v15:
> > - Put (*set_freqs_pct) and (*get_vops) in struct svs_bank because they are
> > part of svs bank's operation
> > - Add define "SVSB_INIT02_RM_DVTFIXED" and "SVSB_MON_VOLT_IGNORE" to make
> > control clearly.
> > - Remove unnecessary parenthesis
> > 
> > Roger Lu (7):
> >    [v16,1/7] dt-bindings: soc: mediatek: add mtk svs dt-bindings
> >    [v16,2/7] arm64: dts: mt8183: add svs device information
> >    [v16,3/7] soc: mediatek: SVS: introduce MTK SVS engine
> >    [v16,4/7] soc: mediatek: SVS: add debug commands
> >    [v16,5/7] dt-bindings: soc: mediatek: add mt8192 svs dt-bindings
> >    [v16,6/7] arm64: dts: mt8192: add svs device information
> >    [v16,7/7] soc: mediatek: SVS: add mt8192 SVS GPU driver
> > 
> >   .../bindings/soc/mediatek/mtk-svs.yaml        |   92 +
> >   arch/arm64/boot/dts/mediatek/mt8183.dtsi      |   18 +
> >   arch/arm64/boot/dts/mediatek/mt8192.dtsi      |   34 +
> >   drivers/soc/mediatek/Kconfig                  |   10 +
> >   drivers/soc/mediatek/Makefile                 |    1 +
> >   drivers/soc/mediatek/mtk-svs.c                | 2524 +++++++++++++++++
> >   6 files changed, 2679 insertions(+)
> >   create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mtk-
> > svs.yaml
> >   create mode 100644 drivers/soc/mediatek/mtk-svs.c
> > 
> > _______________________________________________
> > Linux-mediatek mailing list
> > Linux-mediatek@...ts.infradead.org
> > 
https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!yy2e7JqE__BQAZF3jwBuR3Fbzbv8LPxwwA3l6SVu7SFAG94dCHyVq9A3MIj4Pohu$
> >  
> > 

Powered by blists - more mailing lists