linux-kernel - Re: [PATCH 5.4 14/37] net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <800ce698-c657-b512-33c3-722f6f22c49b@gmail.com>
Date:   Mon, 3 Jan 2022 10:34:53 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org
Cc:     stable@...r.kernel.org, Miaoqian Lin <linmq006@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.4 14/37] net: phy: fixed_phy: Fix NULL vs IS_ERR()
 checking in __fixed_phy_register



On 1/3/2022 6:23 AM, Greg Kroah-Hartman wrote:
> From: Miaoqian Lin <linmq006@...il.com>
> 
> [ Upstream commit b45396afa4177f2b1ddfeff7185da733fade1dc3 ]
> 
> The fixed_phy_get_gpiod function() returns NULL, it doesn't return error
> pointers, using NULL checking to fix this.i
> 
> Fixes: 5468e82f7034 ("net: phy: fixed-phy: Drop GPIO from fixed_phy_add()")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> Link: https://lore.kernel.org/r/20211224021500.10362-1-linmq006@gmail.com
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Sasha Levin <sashal@...nel.org>

This patch prevents systems using fixed PHY devices from successfully 
registering, especially when those systems have a fixed PHY that does 
not use a GPIO:

[    5.971952] brcm-systemport 9300000.ethernet: failed to register 
fixed PHY
[    5.978854] brcm-systemport: probe of 9300000.ethernet failed with 
error -22
[    5.986047] brcm-systemport 9400000.ethernet: failed to register 
fixed PHY
[    5.992947] brcm-systemport: probe of 9400000.ethernet failed with 
error -22

Please drop it for now until it can be investigated. Thanks!
-- 
Florian