linux-kernel - Re: [Regression] md/raid1: write-intent logging/bitmap issue since fd3b6975e9c1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <D0600716-A336-4622-9A99-6EC4BA4D3B58@fb.com>
Date:   Mon, 3 Jan 2022 21:59:25 +0000
From:   Song Liu <songliubraving@...com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Norbert Warmuth <nwarmuth@...nline.de>,
        Jens Axboe <axboe@...nel.dk>,
        Guoqing Jiang <guoqing.jiang@...ux.dev>,
        "linux-raid@...r.kernel.org" <linux-raid@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [Regression] md/raid1: write-intent logging/bitmap issue since
 fd3b6975e9c1 - v5.16-rc1



> On Jan 3, 2022, at 11:53 AM, Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> 
> [ Jens wasn't cc'd for some reason but was the signer-off-on the patch
> you bisected to. Added him to the cc. I'll bounce the original
> separately, as I also don't see this on lore.kernel.org - it might not
> have gotten there yet ]
> 
> On Mon, Jan 3, 2022 at 11:30 AM Norbert Warmuth <nwarmuth@...nline.de> wrote:
>> 
>> Please verify and either revert or fixup fd3b6975e9c1 if my analysis is
>> correct.
> 
> Can you check if moving the WriteMostly bit to the "do behind I/O?"
> section fixes things for you?
> 
> IOW, something like the attached patch..
> 
> Warning: This is very much a "Money see, monkey do" patch. I'm not
> really familiar with the raid1 code ]
> 
> But yeah, if you see corruption and there isn't an absolutely trivial
> fix for this, we should revert.
> 
>           Linus
> <patch.diff>

I can confirm this patch fixes the issue. I will send pull request with 
the fix shortly. 

Thanks,
Song