linux-kernel - [PATCH v3 net-next 0/3] net: skb: introduce kfree_skb_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220104032134.1239096-1-imagedong@tencent.com>
Date:   Tue,  4 Jan 2022 11:21:31 +0800
From:   menglong8.dong@...il.com
To:     rostedt@...dmis.org, kuba@...nel.org, dsahern@...nel.org
Cc:     mingo@...hat.com, davem@...emloft.net, nhorman@...driver.com,
        edumazet@...gle.com, yoshfuji@...ux-ipv6.org,
        jonathan.lemon@...il.com, alobakin@...me, keescook@...omium.org,
        cong.wang@...edance.com, talalahmad@...gle.com, haokexin@...il.com,
        imagedong@...cent.com, atenart@...nel.org, bigeasy@...utronix.de,
        weiwan@...gle.com, arnd@...db.de, pabeni@...hat.com,
        vvs@...tuozzo.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, mengensun@...cent.com,
        mungerjiang@...cent.com
Subject: [PATCH v3 net-next 0/3] net: skb: introduce kfree_skb_with_reason()

From: Menglong Dong <imagedong@...cent.com>

In this series patch, the interface kfree_skb_with_reason() is
introduced(), which is used to collect skb drop reason, and pass
it to 'kfree_skb' tracepoint. Therefor, 'drop_monitor' or eBPF is
able to monitor abnormal skb with detail reason.

In fact, this series patches are out of the intelligence of David
and Steve, I'm just a truck man :/

Previous discussion is here:

https://lore.kernel.org/netdev/20211118105752.1d46e990@gandalf.local.home/
https://lore.kernel.org/netdev/67b36bd8-2477-88ac-83a0-35a1eeaf40c9@gmail.com/

In the first patch, kfree_skb_with_reason() is introduced and
the 'reason' field is added to 'kfree_skb' tracepoint. In the
second patch, 'kfree_skb()' in replaced with 'kfree_skb_with_reason()'
in tcp_v4_rcv(). In the third patch, 'kfree_skb_with_reason()' is
used in __udp4_lib_rcv().

Changes since v2:
- rename kfree_skb_with_reason() to kfree_skb_reason()
- make kfree_skb() static inline, as Jakub suggested

Changes since v1:
- rename some drop reason, as David suggested
- add the third patch


Menglong Dong (3):
  net: skb: introduce kfree_skb_reason()
  net: skb: use kfree_skb_reason() in tcp_v4_rcv()
  net: skb: use kfree_skb_reason() in __udp4_lib_rcv()

 include/linux/skbuff.h     | 28 +++++++++++++++++++++++++-
 include/trace/events/skb.h | 40 +++++++++++++++++++++++++++++++-------
 net/core/dev.c             |  3 ++-
 net/core/drop_monitor.c    | 10 +++++++---
 net/core/skbuff.c          | 12 +++++++-----
 net/ipv4/tcp_ipv4.c        | 14 ++++++++++---
 net/ipv4/udp.c             | 10 ++++++++--
 7 files changed, 95 insertions(+), 22 deletions(-)

-- 
2.27.0