[<prev] [next>] [day] [month] [year] [list]
Message-ID: <CAL_JsqKJJutPpc-xRK0y+t8s=jpqkBmHMgaFK1mnEcxPT98vjQ@mail.gmail.com>
Date: Tue, 4 Jan 2022 14:31:31 -0600
From: Rob Herring <robh@...nel.org>
To: Lh Kuo 郭力豪 <lh.Kuo@...plus.com>
Cc: "LH.Kuo" <lhjeff911@...il.com>,
"p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
"daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
"lee.jones@...aro.org" <lee.jones@...aro.org>,
"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
"ulf.hansson@...aro.org" <ulf.hansson@...aro.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"qinjian@...lus1.com" <qinjian@...lus1.com>,
Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: Re: [PATCH v2 2/2] devicetree bindings mmc Add bindings doc for
Sunplus SP7021
On Tue, Nov 30, 2021 at 7:59 PM Lh Kuo 郭力豪 <lh.Kuo@...plus.com> wrote:
>
> > > > > +properties:
> > > > > + compatible:
> > > > > + enum:
> > > > > + - sunplus,sp7021-card1
> > > > > + - sunplus,sp7021-sdio
> > > >
> > > > What's the difference between these 2 blocks?
> > > >
> > >
> > > One for SD card One for SDIO
> >
> > If the programming model is the same, then it should be the same compatible string. We have various
> > properties to handle differences like bus width, card detect or not, etc.
> >
>
> SDIO and SDCARD still need to set the date and CMD decoding differences.
I still don't understand. A host controller should be able to
initialize a card enough to tell what kind it is. And we have things
defined in DT like 'no-sd' and 'no-mmc'.
Looking at the driver, the difference appears to be just setting a
register to the mode (eMMC/SD/SDIO). That's not a difference in the
h/w block which is when different compatibles would be appropriate. A
property, if anything, is the right thing to do here.
Rob
Powered by blists - more mailing lists