linux-kernel - Re: [PATCH v3 2/2] devicetree bindings mmc Add bindings doc for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdSv53g+js4MnkEY@robh.at.kernel.org>
Date:   Tue, 4 Jan 2022 14:36:55 -0600
From:   Rob Herring <robh@...nel.org>
To:     Li-hao Kuo <lhjeff911@...il.com>
Cc:     p.zabel@...gutronix.de, daniel.thompson@...aro.org,
        lee.jones@...aro.org, u.kleine-koenig@...gutronix.de,
        ulf.hansson@...aro.org, linux-kernel@...r.kernel.org,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        lh.kuo@...plus.com, wells.lu@...plus.com
Subject: Re: [PATCH v3 2/2] devicetree bindings mmc Add bindings doc for
 Sunplus SP7021

On Fri, Dec 24, 2021 at 02:05:39PM +0800, Li-hao Kuo wrote:
> Add devicetree bindings mmc Add bindings doc for Sunplus SP7021
> 
> Signed-off-by: Li-hao Kuo <lhjeff911@...il.com>
> ---
> Changes in v3:
>  - Addressed all comments from Mr. Rob Herring

No. The subject is still wrong and my comments on compatible still 
remain. For the latter, I just replied on the original thread.

>  - Modified SD/SDIO driver.

Wrong patch. And modified how? You need to list the changes from the 
last version one by one. This list should give the reviewer a clue as to 
which parts need to be reviewed again so we don't have to review the 
whole thing again nor remember what we said to change. The reviewer has 
probably reviewed 10s to 100 patches since the last version and doesn't 
remember what they said.

> 
>  .../devicetree/bindings/mmc/sunplus-sd2.yaml       | 73 ++++++++++++++++++++++
>  MAINTAINERS                                        |  1 +
>  2 files changed, 74 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml b/Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
> new file mode 100644
> index 0000000..2f96e35
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
> @@ -0,0 +1,73 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mmc/sunplus-sd2.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sunplus SD/SDIO controller
> +
> +maintainers:
> +  - Li-hao Kuo <lhjeff911@...il.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - sunplus,sp7021-card
> +      - sunplus,sp7021-sdio
> +
> +  reg:
> +    items:
> +      - description: Base address and length of the SD/SDIO registers
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  resets:
> +    maxItems: 1
> +
> +  max-frequency: true
> +
> +allOf:
> +  - $ref: "mmc-controller.yaml"
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - clocks
> +  - resets
> +  - pinctrl-names
> +  - pinctrl-0
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/clock/sp-sp7021.h>
> +    #include <dt-bindings/reset/sp-sp7021.h>
> +    #include <dt-bindings/interrupt-controller/irq.h>
> +    sdcard: sdcard@...03e80 {
> +       compatible = "sunplus,sp7021-card";
> +       reg = <0x9c003e80 0x280>;
> +       interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;
> +       clocks = <&clkc CARD_CTL1>;
> +       resets = <&rstc RST_CARD_CTL1>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&mmc1_mux &mmc1_mux_cd>;
> +       max-frequency = <52000000>;
> +    };
> +    sdio: mmc@...08400 {
> +       compatible = "sunplus,sp7021-sdio";
> +       reg = <0x9c008400 0x280>;
> +       interrupts = <21 IRQ_TYPE_LEVEL_HIGH>;
> +       clocks = <&clkc CARD_CTL1>;
> +       resets = <&rstc RST_CARD_CTL1>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pins_sdio>;
> +       max-frequency = <52000000>;
> +    };
> +...
> \ No newline at end of file
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2c1d9e8..297d512 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18246,6 +18246,7 @@ SUNPLUS SD/SDIO HOST CONTROLLER INTERFACE DRIVER
>  M:	Li-hao Kuo <lhjeff911@...il.com>
>  L:	linux-mmc@...r.kernel.org
>  S:	Maintained
> +F:	Documentation/devicetree/bindings/mmc/sunplus-sd2.yaml
>  F:	drivers/mmc/host/sunplus_sd2.c
>  
>  SUPERH
> -- 
> 2.7.4
> 
>