linux-kernel - Re: [PATCH v2] platform/chrome: cros_ec: Make cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Jan 2022 00:19:08 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Guenter Roeck <groeck@...gle.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Guenter Roeck <groeck@...omium.org>,
        Benson Leung <bleung@...omium.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        kernel@...gutronix.de
Subject: Re: [PATCH v2] platform/chrome: cros_ec: Make cros_ec_unregister()
 return return void

Hello,

On Wed, Oct 20, 2021 at 05:54:24AM -0700, Guenter Roeck wrote:
> On Wed, Oct 20, 2021 at 12:17 AM Uwe Kleine-König
> <u.kleine-koenig@...gutronix.de> wrote:
> >
> > Up to now cros_ec_unregister() returns zero unconditionally. Make it
> > return void instead which makes it easier to see in the callers that
> > there is no error to handle.
> >
> > Also the return value of i2c, platform and spi remove callbacks is
> > ignored anyway.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Reviewed-by: Guenter Roeck <groeck@...omium.org>

This patch is one of the very few ones that are still required to change
spi_driver::remove to return void.

It doesn't appear in next up to now. Who feels responsible to merge it?
If it's still possible to go in during the next merge window this would
be great. I guess we'll have to prepare an unmutable branch to change
struct spi_driver and the patch can also be included there.

Whatever works best for the involved maintainers ... I just have to know
your preferences.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)