linux-kernel - RE: [PATCH] ARM: dts: add DT for lan966x SoC and 2-port board pcb8291

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB48651B354ABAF04ABB53FB04924A9@CO1PR11MB4865.namprd11.prod.outlook.com>
Date:   Tue, 4 Jan 2022 05:20:18 +0000
From:   <Kavyasree.Kotagiri@...rochip.com>
To:     <Tudor.Ambarus@...rochip.com>, <arnd@...db.de>, <olof@...om.net>,
        <robh+dt@...nel.org>, <Nicolas.Ferre@...rochip.com>
CC:     <soc@...nel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <Manohar.Puri@...rochip.com>
Subject: RE: [PATCH] ARM: dts: add DT for lan966x SoC and 2-port board pcb8291

> On 1/3/22 2:48 PM, Kavyasree Kotagiri wrote:
> > diff --git a/arch/arm/boot/dts/lan966x_pcb8291.dts
> b/arch/arm/boot/dts/lan966x_pcb8291.dts
> > new file mode 100644
> > index 000000000000..cd0454a795e7
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/lan966x_pcb8291.dts
> > @@ -0,0 +1,55 @@
> 
> > +&flx3 {
> > +       atmel,flexcom-mode = <ATMEL_FLEXCOM_MODE_USART>;
> > +       status = "okay";
> > +
> > +       usart0: serial@200 {
> > +               compatible = "atmel,at91sam9260-usart";
> 
> The flexcom usart mode should be defined in the dtsi file, so that you
> won't duplicate the definition in each dts that includes the dtsi file.
> 
defining flexcom mode in dts as flx3 can be used as USART/I2C/SPI on different boards.
And it is not the same mode for all boards.

> Cheers,
> ta