linux-kernel - Re: [PATCH 5.15 28/73] net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdP4UpzF99+bOAoF@kroah.com>
Date:   Tue, 4 Jan 2022 08:33:38 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Miaoqian Lin <linmq006@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 28/73] net: phy: fixed_phy: Fix NULL vs IS_ERR()
 checking in __fixed_phy_register

On Mon, Jan 03, 2022 at 11:47:34AM -0800, Florian Fainelli wrote:
> 
> 
> On 1/3/2022 6:23 AM, Greg Kroah-Hartman wrote:
> > From: Miaoqian Lin <linmq006@...il.com>
> > 
> > [ Upstream commit b45396afa4177f2b1ddfeff7185da733fade1dc3 ]
> > 
> > The fixed_phy_get_gpiod function() returns NULL, it doesn't return error
> > pointers, using NULL checking to fix this.i
> > 
> > Fixes: 5468e82f7034 ("net: phy: fixed-phy: Drop GPIO from fixed_phy_add()")
> > Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> > Link: https://lore.kernel.org/r/20211224021500.10362-1-linmq006@gmail.com
> > Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> 
> Same as 5.4 and 5.10, this patch causes a regression on 5.15 as well and
> should be dropped. Since this is also affecting Linus' master a revert of
> that changes has been submitted to the net/master tree and should reach
> Linus' tree shortly assuming it gets applied:
> 
> https://lore.kernel.org/lkml/20220103193453.1214961-1-f.fainelli@gmail.com/

Thanks, I have dropped this from all 3 stable queues now.

greg k-h