linux-kernel - Re: [PATCH] usb: dwc2: Simplify a bitmap declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Jan 2022 07:39:36 +0000
From:   Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] usb: dwc2: Simplify a bitmap declaration

On 12/23/2021 11:40 AM, Christophe JAILLET wrote:
> Use DECLARE_BITMAP() instead of hand writing it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Acked-by: Minas Harutyunyan <Minas.Harutyunyan@...opsys.com>

> ---
>   drivers/usb/dwc2/core.h | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index e2fe64239328..8a63da3ab39d 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -1154,8 +1154,7 @@ struct dwc2_hsotg {
>   	struct list_head periodic_sched_queued;
>   	struct list_head split_order;
>   	u16 periodic_usecs;
> -	unsigned long hs_periodic_bitmap[
> -		DIV_ROUND_UP(DWC2_HS_SCHEDULE_US, BITS_PER_LONG)];
> +	DECLARE_BITMAP(hs_periodic_bitmap, DWC2_HS_SCHEDULE_US);
>   	u16 periodic_qh_count;
>   	bool new_connection;
>