linux-kernel - Re: [PATCH] virt: acrn: fix memory leak in acrn_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdQfCGf8qr5zZJef@kroah.com>
Date:   Tue, 4 Jan 2022 11:18:48 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Zhou Qingyang <zhou1615@....edu>
Cc:     kjlu@....edu, Fei Li <fei1.li@...el.com>,
        Shuo Liu <shuo.a.liu@...el.com>,
        Zhi Wang <zhi.a.wang@...el.com>,
        Reinette Chatre <reinette.chatre@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] virt: acrn: fix memory leak in acrn_dev_ioctl()

On Tue, Jan 04, 2022 at 04:53:21PM +0800, Zhou Qingyang wrote:
> In acrn_dev_ioctl(), cpu_regs is not released or passed out on several 
> error paths which could lead to memory leak bug.
> 
> Fix this bug by adding kfree of cpu_regs on error paths.
> 
> This bug was found by a static analyzer.
> 
> Builds with CONFIG_ACRN_GUEST=y, CONFIG_ACRN_HSM=y show no new warnings,
> and our static analyzer no longer warns about this code.
> 
> Fixes: 2ad2aaee1bc9 ("virt: acrn: Introduce an ioctl to set vCPU registers state")
> Signed-off-by: Zhou Qingyang <zhou1615@....edu>
> ---
> The analysis employs differential checking to identify inconsistent
> security operations (e.g., checks or kfrees) between two code paths
> and confirms that the inconsistent operations are not recovered in
> the current function or the callers, so they constitute bugs.
> 
> Note that, as a bug found by static analysis, it can be a false
> positive or hard to trigger. Multiple researchers have cross-reviewed
> the bug.

Then why have all of those researchers put their reviewed-by on this
change?

Note that your university is still in many kernel maintainer's
ignore-list (myself included, I dug this up as I saw Fei's response.)
Please work with your administration and the process that is currently
happening in order to give you all the needed training so you will not
keep causing these types of basic errors that keep your patches from
being accepted.

*plonk*

greg k-h