linux-kernel - Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 4 Jan 2022 10:38:16 +0000
From:   "lizhijian@...itsu.com" <lizhijian@...itsu.com>
To:     Christoph Hellwig <hch@...radead.org>
CC:     "zyjzyj2000@...il.com" <zyjzyj2000@...il.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "leon@...nel.org" <leon@...nel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lizhijian@...itsu.com" <lizhijian@...itsu.com>
Subject: Re: [PATCH v2] RDMA/rxe: Get rid of redundant plus



On 04/01/2022 15:54, Christoph Hellwig wrote:
> On Tue, Jan 04, 2022 at 09:24:06AM +0800, Li Zhijian wrote:
>> --- a/drivers/infiniband/sw/rxe/rxe_opcode.c
>> +++ b/drivers/infiniband/sw/rxe/rxe_opcode.c
>> @@ -879,9 +879,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>>   			[RXE_ATMETH]	= RXE_BTH_BYTES
>>   						+ RXE_RDETH_BYTES
>>   						+ RXE_DETH_BYTES,
>> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
>> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>>   						+ RXE_ATMETH_BYTES
>> -						+ RXE_DETH_BYTES +
>> +						+ RXE_DETH_BYTES
>>   						+ RXE_RDETH_BYTES,
>>   		}
>>   	},
>> @@ -900,9 +900,9 @@ struct rxe_opcode_info rxe_opcode[RXE_NUM_OPCODE] = {
>>   			[RXE_ATMETH]	= RXE_BTH_BYTES
>>   						+ RXE_RDETH_BYTES
>>   						+ RXE_DETH_BYTES,
>> -			[RXE_PAYLOAD]	= RXE_BTH_BYTES +
>> +			[RXE_PAYLOAD]	= RXE_BTH_BYTES
>>   						+ RXE_ATMETH_BYTES
>> -						+ RXE_DETH_BYTES +
>> +						+ RXE_DETH_BYTES
>>   						+ RXE_RDETH_BYTES,
>>   		}
>>   	},
> Please fix this up to always have the + on the continuing line which
> is the normal kernel style.
I'm so glad to hear that, i will also update the existing unconventional style in this file.