linux-kernel - Re: [PATCH 1/2] EDAC: use proper list of struct attribute for attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdQmzoNOBHLwgv7p@kroah.com>
Date:   Tue, 4 Jan 2022 11:51:58 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     linux-kernel@...r.kernel.org, Borislav Petkov <bp@...en8.de>
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>, linux-edac@...r.kernel.org
Subject: Re: [PATCH 1/2] EDAC: use proper list of struct attribute for
 attributes

On Tue, Jan 04, 2022 at 11:38:21AM +0100, Greg Kroah-Hartman wrote:
> The edac sysfs code is doing some crazy casting of the list of
> attributes that is not necessary at all.  Instead, properly point to the
> correct attribute structure in the lists, which removes the need to cast
> anything and the code is now properly typesafe (as much as sysfs
> attribute logic is typesafe...)
> 
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: Tony Luck <tony.luck@...el.com>
> Cc: James Morse <james.morse@....com>
> Cc: Robert Richter <rric@...nel.org>
> Cc: linux-edac@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  drivers/edac/edac_device_sysfs.c | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Ick, I forgot the other users like edac_pci_sysfs.c that also has this
issue, so let me go fix up this series to include that at the same time.
Sorry for the noise here...

thanks,

greg k-h