linux-kernel - Re: [PATCH] tracing/osnoise: Fix sparse warning in function start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <de6126fb-68db-7369-a14a-1172f0899e91@kernel.org>
Date:   Tue, 4 Jan 2022 11:12:15 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Wang ShaoBo <bobo.shaobowang@...wei.com>, rostedt@...dmis.org
Cc:     xiexiuqi@...wei.com, cj.chengjian@...wei.com, liwei391@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing/osnoise: Fix sparse warning in function
 start_kthread

On 1/4/22 10:48, Wang ShaoBo wrote:
> Change main to main_func to fix following sparse warning:
> 
> kernel/trace/trace_osnoise.c: In function ‘start_kthread’:
> kernel/trace/trace_osnoise.c:1674:8: warning: ‘main’ is usually a function [-Wmain]
>   void *main = osnoise_main;
>         ^~~~

NAK!

This was already discussed... many times. The problem is not in the usage of
main as a variable name but in the tool that you are using. Try to fix your tool.

E.g., https://lore.kernel.org/lkml/20210813224131.25803-1-rdunlap@infradead.org/

-- Daniel