linux-kernel - Re: [PATCH v2 5/5] erofs: use meta buffers for zmap operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <22e4925b-5e85-141a-1e59-c140d35af0be@kernel.org>
Date:   Tue, 4 Jan 2022 20:44:13 +0800
From:   Chao Yu <chao@...nel.org>
To:     Gao Xiang <hsiangkao@...ux.alibaba.com>
Cc:     linux-erofs@...ts.ozlabs.org, Liu Bo <bo.liu@...ux.alibaba.com>,
        LKML <linux-kernel@...r.kernel.org>, Yue Hu <huyue2@...ong.com>
Subject: Re: [PATCH v2 5/5] erofs: use meta buffers for zmap operations

On 2022/1/4 17:02, Gao Xiang wrote:
> Thanks for the question. Previously, erofs_get_meta_page was called
> independently without reusing zmap mpage, so the page refcount had no
> relationship with zmap mpage.
> 
> However, now we reuse zmap metabuf instead(fe->map.buf), so an extra
> page refcount is needed since zmap metabuf will be released at the end
> of readpage or readahead...

Thanks for the explanation.

Reviewed-by: Chao Yu <chao@...nel.org>

Thanks,