linux-kernel - Re: [PATCH] block: remove dead queue_dma_alignment branch from bio_map_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220104124724.GA21670@lst.de>
Date:   Tue, 4 Jan 2022 13:47:24 +0100
From:   Christoph Hellwig <hch@....de>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Christoph Hellwig <hch@....de>, Jens Axboe <axboe@...nel.dk>,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] block: remove dead queue_dma_alignment branch from
 bio_map_user_iov()

On Tue, Jan 04, 2022 at 01:01:58PM +0100, Lukas Bulwahn wrote:
> If queue_dma_alignment(rq->q), then blk_rq_map_user_iov() will call
> bio_copy_user_iov() and not bio_map_user_iov(). So, bio_map_user_iov() does
> not need to handle the queue_dma_alignment(rq->q) case in any special way.
> 
> Remove this dead branch from bio_map_user_iov().

Looks good:

Reviewed-by: Christoph Hellwig <hch@....de>