[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAG3jFytHBizw_kxbjgRkv0WcxJE1LsKhO7X98fDGSqCzh2kafA@mail.gmail.com>
Date: Tue, 4 Jan 2022 14:13:05 +0100
From: Robert Foss <robert.foss@...aro.org>
To: Miaoqian Lin <linmq006@...il.com>
Cc: Andrzej Hajda <a.hajda@...sung.com>,
Neil Armstrong <narmstrong@...libre.com>,
Laurent Pinchart <laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
David Airlie <airlied@...ux.ie>,
Daniel Vetter <daniel@...ll.ch>, Sean Young <sean@...s.org>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Maciej Purski <m.purski@...sung.com>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/bridge: Fix free wrong object in sii8620_init_rcp_input_dev
On Mon, 27 Dec 2021 at 10:25, Miaoqian Lin <linmq006@...il.com> wrote:
>
> rc_dev is allocated by rc_allocate_device(), and doesn't assigned to
> ctx->rc_dev before calling rc_free_device(ctx->rc_dev).
> So it should call rc_free_device(rc_dev);
>
> Fixes: e25f1f7 ("drm/bridge/sii8620: add remote control support")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>
> ---
> drivers/gpu/drm/bridge/sil-sii8620.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/bridge/sil-sii8620.c b/drivers/gpu/drm/bridge/sil-sii8620.c
> index 843265d7f1b1..ec7745c31da0 100644
> --- a/drivers/gpu/drm/bridge/sil-sii8620.c
> +++ b/drivers/gpu/drm/bridge/sil-sii8620.c
> @@ -2120,7 +2120,7 @@ static void sii8620_init_rcp_input_dev(struct sii8620 *ctx)
> if (ret) {
> dev_err(ctx->dev, "Failed to register RC device\n");
> ctx->error = ret;
> - rc_free_device(ctx->rc_dev);
> + rc_free_device(rc_dev);
> return;
> }
> ctx->rc_dev = rc_dev;
> --
Reviewed-by: Robert Foss <robert.foss@...aro.org>
Powered by blists - more mailing lists