lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20220104132026.3062763-1-dario.binacchi@amarulasolutions.com>
Date:   Tue,  4 Jan 2022 14:20:24 +0100
From:   Dario Binacchi <dario.binacchi@...rulasolutions.com>
To:     linux-kernel@...r.kernel.org
Cc:     Michael Trimarchi <michael@...rulasolutions.com>,
        Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        linux-can@...r.kernel.org, netdev@...r.kernel.org
Subject: [RFC PATCH 0/2] Change flexcan features at runtime

This series was born from the review https://lkml.org/lkml/2022/1/2/127
by Marc Kleine-Budde. The ethtool module is minimal and lacks the
callback to change the setting at runtime (this has yet to be defined).
I'm certainly not an expert but might it make sense to use the
set_features() callback? Although I understand that it belongs to
`struct net_device_ops' and not to 'struct ethtool_ops'.


Dario Binacchi (2):
  can: flexcan: allow to change quirks at runtime
  can: flexcan: add ethtool support

 drivers/net/can/Makefile                      |   3 +
 drivers/net/can/flexcan.h                     | 107 +++++++++++++
 drivers/net/can/flexcan_ethtool.c             |  29 ++++
 drivers/net/can/{flexcan.c => flexcan_main.c} | 144 ++++--------------
 4 files changed, 166 insertions(+), 117 deletions(-)
 create mode 100644 drivers/net/can/flexcan.h
 create mode 100644 drivers/net/can/flexcan_ethtool.c
 rename drivers/net/can/{flexcan.c => flexcan_main.c} (92%)

-- 
2.32.0

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ