linux-kernel - Re: [Intel-wired-lan] [PATCH] intel: Simplify DMA setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220104132936.252202-1-alexandr.lobakin@intel.com>
Date:   Tue,  4 Jan 2022 14:29:36 +0100
From:   Alexander Lobakin <alexandr.lobakin@...el.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     Alexander Lobakin <alexandr.lobakin@...el.com>,
        Christoph Hellwig <hch@...radead.org>,
        jesse.brandeburg@...el.com, anthony.l.nguyen@...el.com,
        davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, intel-wired-lan@...ts.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH] intel: Simplify DMA setting

From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Date: Tue, 4 Jan 2022 01:15:20 +0100

> As stated in [1], dma_set_mask() with a 64-bit mask will never fail if
> dev->dma_mask is non-NULL.
> So, if it fails, the 32 bits case will also fail for the same reason.
> 
> Simplify code and remove some dead code accordingly.
> 
> [1]: https://lkml.org/lkml/2021/6/7/398
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c    | 22 ++++++-------------
>  drivers/net/ethernet/intel/i40e/i40e_main.c   |  9 +++-----
>  drivers/net/ethernet/intel/iavf/iavf_main.c   |  9 +++-----
>  drivers/net/ethernet/intel/ice/ice_main.c     |  2 --
>  drivers/net/ethernet/intel/ixgb/ixgb_main.c   | 19 +++++-----------
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 20 ++++++-----------
>  .../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 20 +++++------------
>  7 files changed, 31 insertions(+), 70 deletions(-)

I like it, thanks!

Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>

Tony might ask to split it into per-driver patches tho, will see.

--- 8< ---

Al