linux-kernel - Re: hda/cs8409: Fix internal speaker detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hmtkbjz2e.wl-tiwai@suse.de>
Date:   Tue, 04 Jan 2022 16:33:13 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     "Christian A. Ehrhardt" <lk@...e.de>
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        Lucas Tanure <tanureal@...nsource.cirrus.com>,
        Stefan Binding <sbinding@...nsource.cirrus.com>,
        Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>
Subject: Re: hda/cs8409: Fix internal speaker detection

On Fri, 31 Dec 2021 14:12:21 +0100,
Christian A. Ehrhardt wrote:
> 
> 
> Hi,
> 
> I have a DELL Inspirion 3501 laptop with a cirrus cs8904 HDA codec.
> With more recent kernels the internal speakers stopped working.
> I bisected the issue and tracked it down to this commit 
> 
> | commit c8b4f0865e82c14924c69c07d985af3ee9133316
> | Author: Stefan Binding <sbinding@...nsource.cirrus.com>
> | Date:   Wed Aug 11 19:56:52 2021 +0100
> |
> |     ALSA: hda/cs8409: Remove unnecessary delays
>         
> After a bit of experimenting with the timeouts I came
> up with the patch below that fixes the issue for me.
> 
> However, I don't have the specs for the chip, i.e. I don't
> know what a theoretically correct value would be.
> 
> Suggested patch below, please consider inclusion.
> 
>      regards   Christian
> 
> >From 9c796d221171c6d12fd84ae4f5c8315030c8c4ca Mon Sep 17 00:00:00 2001
> From: "Christian A. Ehrhardt" <lk@...e.de>
> Date: Fri, 31 Dec 2021 10:33:19 +0100
> Subject: [PATCH 1/2] ALSA: hda/cs8409: Increase delay during jack detection
> 
> Commit c8b4f0865e82 reduced delays related to cs42l42 jack
> detection. However, the change was too aggressive. As a result
> internal speakers on DELL Inspirion 3501 ac8b4f0865e82re not detected.
> 
> Increase the delay in cs42l42_run_jack_detect() a bit.
> 
> Fixes: c8b4f0865e82 ("ALSA: hda/cs8409: Remove unnecessary delays")
> Signed-off-by: Christian A. Ehrhardt <lk@...e.de>

Thanks, applied now.


Takashi