linux-kernel - Re: [PATCH v2] ieee802154: atusb: fix uninit value in atusb_set_extended

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1f63e82-7a3f-7cf9-ddb3-fc0a863dce40@gmail.com>
Date:   Tue, 4 Jan 2022 21:11:25 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Stefan Schmidt <stefan@...enfreihafen.org>, alex.aring@...il.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     linux-wpan@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexander Potapenko <glider@...gle.com>
Subject: Re: [PATCH v2] ieee802154: atusb: fix uninit value in
 atusb_set_extended_addr

On 1/4/22 21:04, Stefan Schmidt wrote:
>> Hi Stefan,
>> 
>> thanks for testing on real hw.
>> 
>> It looks like there is corner case, that Greg mentioned in this thread. 
>> atusb_get_and_show_build() reads firmware build info, which may have 
>> various length.
>> 
>> Maybe we can change atusb_control_msg() to usb_control_msg() in 
>> atusb_get_and_show_build(), since other callers do not have this problem
> 
> That works for me.
> 

Nice! Will prepare v3.


Thanks for testing once again!

> I will also have a look at the use of the modern USB API for next. The
> fix here has a higher prio for me to get in and backported though. Once
> we have this we can look at bigger changes in atusb.
> 


With regards,
Pavel Skripkin