linux-kernel - Re: [PATCH v1 1/1] Revert "net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20220103191515.66280992@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Mon, 3 Jan 2022 19:17:29 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sam Ravnborg <sam@...nborg.org>
Cc:     Miaoqian Lin <linmq006@...il.com>, davem@...emloft.net,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/1] Revert "net: phy: fixed_phy: Fix NULL vs
 IS_ERR() checking in __fixed_phy_register"

On Sun,  2 Jan 2022 12:35:57 +0100 Sam Ravnborg wrote:
> This reverts commit b45396afa4177f2b1ddfeff7185da733fade1dc3.
> 
> With the referenced patch applied the following error was seen
> in the kernel log:
> 
> 	fec 2188000.ethernet: broken fixed-link specification
> 	fec: probe of 2188000.ethernet failed with error -22
> 
> The problem is that the implementation makes the
> link-gpios node mandatory - which is not the case.
> 
> fixed_phy_get_gpiod() may return -EPROBE_DEFER so this code needs
> to use IS_ERR() check and the original code was fine.
> 
> Fixes: b45396afa417 ("net: phy: fixed_phy: Fix NULL vs IS_ERR() checking in __fixed_phy_register")
> Signed-off-by: Sam Ravnborg <sam@...nborg.org>
> Cc: Miaoqian Lin <linmq006@...il.com>
> Cc: Jakub Kicinski <kuba@...nel.org>

This patch didn't register in patchwork for some reason, I applied 
a very similar patch from Florian instead:

https://patchwork.kernel.org/project/netdevbpf/patch/20220103193453.1214961-1-f.fainelli@gmail.com/

Not sure why patchwork and lore did not see your posting, sorry :S