linux-kernel - Re: [Resource Leak] Missing closing files in tools/bpf/bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzY9=Eqs7QnSj0s9uf0_DySO=7ySYXsFzPg2uHKXTbScjg@mail.gmail.com>
Date:   Wed, 5 Jan 2022 15:50:36 -0800
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Ryan Cai <ycaibb@...il.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>, Martin Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        john fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [Resource Leak] Missing closing files in tools/bpf/bpf_asm.c

On Wed, Dec 29, 2021 at 7:40 PM Ryan Cai <ycaibb@...il.com> wrote:
>
> Dear Kernel maintainers,
>               1. In tools/bpf/bpf_asm.c, the file opened at Line 40 may not closed within the function?
>               Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/tools/bpf/bpf_asm.c#L40-L49
>
>               Should it be a bug? I can send patches for these.

file will be closed by the kernel on exit, but it would be better to
close it explicitly, so please feel free to send a fix

>
> Best,
> Ryan
>
>