linux-kernel - Re: [PATCH] trace: remove unneeded initialization in __trace_uprobe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220105185715.0b40cb3f@gandalf.local.home>
Date:   Wed, 5 Jan 2022 18:57:15 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Ingo Molnar <mingo@...hat.com>, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Masami Hiramatsu <mhiramat@...nel.org>
Subject: Re: [PATCH] trace: remove unneeded initialization in
 __trace_uprobe_create()

Masami, want to ack this?

-- Steve


On Mon, 27 Dec 2021 13:53:08 +0100
Lukas Bulwahn <lukas.bulwahn@...il.com> wrote:

> There is no need to initialize ret with 0, as all the early error branches
> simply return constant values, and the default path always reaches
> ret = kern_path(filename, LOOKUP_FOLLOW, &path), which will reset ret
> before the initial value was ever used.
> 
> Remove this unneeded initialization and keep the code succinct.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>
> ---
>  kernel/trace/trace_uprobe.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 5921951a0d5c..9da10c5efdce 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -548,7 +548,6 @@ static int __trace_uprobe_create(int argc, const char **argv)
>  	bool is_return = false;
>  	int i, ret;
>  
> -	ret = 0;
>  	ref_ctr_offset = 0;
>  
>  	switch (argv[0][0]) {