linux-kernel - Re: [PATCH] userfaultfd/selftests: clean up hugetlb allocation code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4e811968-4467-daf7-eb59-1e1827371ebd@oracle.com>
Date:   Tue, 4 Jan 2022 16:24:02 -0800
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Axel Rasmussen <axelrasmussen@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>, Linux MM <linux-mm@...ck.org>,
        Peter Xu <peterx@...hat.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Mina Almasry <almasrymina@...gle.com>,
        Shuah Khan <shuah@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] userfaultfd/selftests: clean up hugetlb allocation code

On 1/4/22 14:35, Axel Rasmussen wrote:
> On Mon, Jan 3, 2022 at 6:17 PM Mike Kravetz <mike.kravetz@...cle.com> wrote:
> 
> Looks functionally correct to me besides the one style gripe,
> 
> Reviewed-by: Axel Rasmussen <axelrasmussen@...gle.com>

Thanks Axel!

The userfaultfd test is not so easy to follow.  While looking at this, I
noticed that we skip the mremap() testing for hugetlb.  However, Mina recently
added hugetlb mremap support.  Unfortunately, mremap hugetlb testing fails
if enabled.  I am still trying to determine the root cause, but would like
to eliminate this special case if possible.
-- 
Mike Kravetz