linux-kernel - Re: [PATCH] mips/pci: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220105085452.GA5406@alpha.franken.de>
Date:   Wed, 5 Jan 2022 09:54:52 +0100
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     cgel.zte@...il.com
Cc:     maz@...nel.org, ilya.lipnitskiy@...il.com, chi.minghao@....com.cn,
        ryazanov.s.a@...il.com, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] mips/pci: remove redundant ret variable

On Tue, Jan 04, 2022 at 11:20:24AM +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from rt3883_pci_r32() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>
> ---
>  arch/mips/pci/pci-rt3883.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c
> index d3c947fa2969..e07ae098bdd8 100644
> --- a/arch/mips/pci/pci-rt3883.c
> +++ b/arch/mips/pci/pci-rt3883.c
> @@ -102,14 +102,12 @@ static u32 rt3883_pci_read_cfg32(struct rt3883_pci_controller *rpc,
>  			       unsigned func, unsigned reg)
>  {
>  	u32 address;
> -	u32 ret;
>  
>  	address = rt3883_pci_get_cfgaddr(bus, slot, func, reg);
>  
>  	rt3883_pci_w32(rpc, address, RT3883_PCI_REG_CFGADDR);
> -	ret = rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA);
>  
> -	return ret;
> +	return rt3883_pci_r32(rpc, RT3883_PCI_REG_CFGDATA);
>  }
>  
>  static void rt3883_pci_write_cfg32(struct rt3883_pci_controller *rpc,
> -- 
> 2.25.1

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]