linux-kernel - Re: [PATCH 2/2] of: unittest: re-implement overlay tracking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdTy2TmEzR+eLHVx@robh.at.kernel.org>
Date:   Tue, 4 Jan 2022 19:22:33 -0600
From:   Rob Herring <robh@...nel.org>
To:     frowand.list@...il.com
Cc:     linux-kernel@...r.kernel.org, erhard_f@...lbox.org,
        Rob Herring <robh+dt@...nel.org>, yinxiujiang@...inos.cn,
        devicetree@...r.kernel.org
Subject: Re: [PATCH 2/2] of: unittest: re-implement overlay tracking

On Fri, 31 Dec 2021 21:33:29 -0600, frowand.list@...il.com wrote:
> From: Frank Rowand <frank.rowand@...y.com>
> 
> Some overlays are tracked when they are applied.  The tracked overlays
> are later removed after the overlay tests are completed.  The old
> implementation makes assumptions about the expected values for
> overlay changeset id created by the overlay apply which result
> in fragile code.  The new code removes the assumptions.
> 
> A symptom that exposes a problem with the tracking code is a
> warning "UBSAN: shift-out-of-bounds in drivers/of/unittest.c:1933:36",
> Kernel Version: 5.15-rc7, PPC-64, Talos II.  This results from variable
> "id" value of -1 in the final line of of_unittest_untrack_overlay().
> 
> Reported-by: erhard_f@...lbox.org
> Signed-off-by: Frank Rowand <frank.rowand@...y.com>
> ---
>  drivers/of/unittest.c | 110 +++++++++++++++++++-----------------------
>  1 file changed, 49 insertions(+), 61 deletions(-)
> 

Applied, thanks!