linux-kernel - Re: [PATCH] crypto: use signed variable to store status and error checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdWLfgy2tID01F8B@silpixa00400314>
Date:   Wed, 5 Jan 2022 12:13:50 +0000
From:   Giovanni Cabiddu <giovanni.cabiddu@...el.com>
To:     Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "open list:QAT DRIVER" <qat-linux@...el.com>,
        "open list:CRYPTO API" <linux-crypto@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] crypto: use signed variable to store status and error
 checking

Thanks for your patch.

Patches to the qat driver have the following headline
     crypto: qat - ...
not just
     crypto: ...

On Wed, Jan 05, 2022 at 02:38:58AM +0500, Muhammad Usama Anjum wrote:
> ret should be signed. adf_cfg_get_param_value and match_string return
Use () when refer to the function().

> signed statuses. The return status may be saved wrongly in unsigned ret
> variable. Correct the data type of ret to signed int.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
After fixing,
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@...el.com>

Regards,

-- 
Giovanni