linux-kernel - Re: [PATCH] iio: gyro: bmg160: Fix error handling in bmg160_core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YdWijUwMwwSWE8+n@smile.fi.intel.com>
Date:   Wed, 5 Jan 2022 15:52:13 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@...wei.com>
Cc:     Miaoqian Lin <linmq006@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        Stephan Gerhold <stephan@...hold.net>,
        Gwendal Grignou <gwendal@...omium.org>,
        Adriana Reus <adi.reus@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: gyro: bmg160: Fix error handling in
 bmg160_core_probe

On Wed, Jan 05, 2022 at 01:07:43PM +0000, Jonathan Cameron wrote:
> On Wed,  5 Jan 2022 12:56:30 +0000
> Miaoqian Lin <linmq006@...il.com> wrote:
> 
> > The pm_runtime_enable will increase power disable depth.
> > If the probe fails, we should use pm_runtime_disable() to balance
> > pm_runtime_enable(). In the PM Runtime docs:
> >     Drivers in ->remove() callback should undo the runtime PM changes done
> >     in ->probe(). Usually this means calling pm_runtime_disable(),
> >     pm_runtime_dont_use_autosuspend() etc.
> > We should do this in error handling.
> > 
> > Fixes: 7d0ead5 ("iio: Reconcile operation order between iio_register/unregister and pm functions")
> 
> Hi Miaoqian,
> 
> Please check this fixes tag against the format it should have.

I usually advise people to put the following in the ~/.gitconfig:

[core]
	abbrev = 12

[alias]
	one = show -s --pretty='format:%h (\"%s\")'
	c = show -s --pretty='format:https://git.kernel.org/torvalds/c/%h'

`git one ...` will give a right thing.

-- 
With Best Regards,
Andy Shevchenko