linux-kernel - Re: [PATCH linux] nfs: Remove unnecessary ret assignment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFX2Jfk3B_sWRsLKu4GZb5NyWVFGUX-s5fX2SSyfFyeQ6MS4VA@mail.gmail.com>
Date:   Wed, 5 Jan 2022 10:36:05 -0500
From:   Anna Schumaker <anna.schumaker@...app.com>
To:     cgel.zte@...il.com
Cc:     Trond Myklebust <trond.myklebust@...merspace.com>,
        Linux NFS Mailing List <linux-nfs@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        luo penghao <luo.penghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH linux] nfs: Remove unnecessary ret assignment

Hi Luo,

On Fri, Dec 31, 2021 at 5:05 AM <cgel.zte@...il.com> wrote:
>
> From: luo penghao <luo.penghao@....com.cn>
>
> Subsequent if judgments will assign new values to ret, so the
> statement here should be deleted
>
> The clang_analyzer complains as follows:
>
> fs/nfs/callback.c:
>
> Value stored to 'ret' is never read

The "else if (xprt->ops->bc_setup)" branch doesn't touch 'ret', so it
seems to me like the clang_analyzer is falsely reporting this.

Thanks,
Anna
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: luo penghao <luo.penghao@....com.cn>
> ---
>  fs/nfs/callback.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfs/callback.c b/fs/nfs/callback.c
> index 86d856d..1c1c82a 100644
> --- a/fs/nfs/callback.c
> +++ b/fs/nfs/callback.c
> @@ -209,7 +209,6 @@ static int nfs_callback_up_net(int minorversion, struct svc_serv *serv,
>                 goto err_bind;
>         }
>
> -       ret = 0;
>         if (!IS_ENABLED(CONFIG_NFS_V4_1) || minorversion == 0)
>                 ret = nfs4_callback_up_net(serv, net);
>         else if (xprt->ops->bc_setup)
> --
> 2.15.2
>
>