linux-kernel - Re: [PATCH] drivers/hwmon: remove redundant res variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd043f81-8605-be9e-4ddd-09711e060c61@roeck-us.net>
Date:   Wed, 5 Jan 2022 07:48:41 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     cgel.zte@...il.com, jdelvare@...e.com
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] drivers/hwmon: remove redundant res variable

On 1/4/22 3:28 AM, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Return value from inb_p() directly instead
> of taking this in another redundant variable.
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> Signed-off-by: CGEL ZTE <cgel.zte@...il.com>

Please do not send me such patches. The subject starts with the wrong tag
(it should have been "hwmon: (nct6683)", it is misleading (the variable is
not redundant; if anything it is unnecessary), and the patch itself adds
zero value. The submitter may have had a reason for using a variable,
may it be personal style or ease of adding a debug statement when testing.
There is no valid reason for changing such code.

Guenter

> ---
>   drivers/hwmon/nct6683.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c
> index 6a9f420e7d32..ab02e967f73d 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -495,13 +495,10 @@ static inline long in_from_reg(u16 reg, u8 src)
>   
>   static u16 nct6683_read(struct nct6683_data *data, u16 reg)
>   {
> -	int res;
> -
>   	outb_p(0xff, data->addr + EC_PAGE_REG);		/* unlock */
>   	outb_p(reg >> 8, data->addr + EC_PAGE_REG);
>   	outb_p(reg & 0xff, data->addr + EC_INDEX_REG);
> -	res = inb_p(data->addr + EC_DATA_REG);
> -	return res;
> +	return inb_p(data->addr + EC_DATA_REG);
>   }
>   
>   static u16 nct6683_read16(struct nct6683_data *data, u16 reg)
>