linux-kernel - Re: [RFC PATCH v2 1/5] Add Parity bit Calculation to regmaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YdXMfX5xayAfRWXe@sirena.org.uk>
Date:   Wed, 5 Jan 2022 16:51:09 +0000
From:   Mark Brown <broonie@...nel.org>
To:     linuxkernel@...utosys.co.uk
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v2 1/5] Add Parity bit Calculation to regmaps

On Wed, Dec 22, 2021 at 06:43:36PM +0000, linuxkernel@...utosys.co.uk wrote:
> From: Christopher Tyerman <c.tyerman@...ebladeautomationsystems.co.uk>
> 
> regmap.h
> 
> Added bitmasks "parity_read_mask" and "parity_write_mask" for read
> and write operations to regmap_config bit mask defines location of
> the parity bit.
> 
> Added optional callback "parity_calc" to regmap_config to
> calculate parity bit value

This is still more a list of changes in the code rather than a normal
changelog which is making it really hard to review - I'm getting lost
with the patch description trying to figure out what the idea here is or
how this is all supposed to fit together.  Like I said last time please
look at submitting-patches.rst.  It's probably also useful to look at
how other kernel changelogs are written and follow a similar style.

Please submit patches using subject lines reflecting the style for the
subsystem, this makes it easier for people to identify relevant patches.
Look at what existing commits in the area you're changing are doing and
make sure your subject lines visually resemble what they're doing.
There's no need to resubmit to fix this alone.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)