linux-kernel - Re: [PATCH] Drivers: hv: vmbus: Initialize request offers message for Isolation VM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220105203945.wyh33cws43enviwx@liuwe-devbox-debian-v2>
Date:   Wed, 5 Jan 2022 20:39:45 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     Juan Vazquez <juvazq@...ux.microsoft.com>
Cc:     kys@...rosoft.com, haiyangz@...rosoft.com, sthemmin@...rosoft.com,
        wei.liu@...nel.org, decui@...rosoft.com, mikelley@...rosoft.com,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Drivers: hv: vmbus: Initialize request offers message
 for Isolation VM

On Wed, Jan 05, 2022 at 11:27:46AM -0800, Juan Vazquez wrote:
> Initialize memory of request offers message to be sent to the host so
> padding or uninitialized fields do not leak guest memory contents.
> 
> Signed-off-by: Juan Vazquez <juvazq@...ux.microsoft.com>

Applied to hyperv-next. Thanks.

> ---
>  drivers/hv/channel_mgmt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
> index 2829575fd9b7..60375879612f 100644
> --- a/drivers/hv/channel_mgmt.c
> +++ b/drivers/hv/channel_mgmt.c
> @@ -1554,7 +1554,7 @@ int vmbus_request_offers(void)
>  	struct vmbus_channel_msginfo *msginfo;
>  	int ret;
>  
> -	msginfo = kmalloc(sizeof(*msginfo) +
> +	msginfo = kzalloc(sizeof(*msginfo) +
>  			  sizeof(struct vmbus_channel_message_header),
>  			  GFP_KERNEL);
>  	if (!msginfo)
> -- 
> 2.32.0
>