| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 6 Jan 2022 05:46:28 +0800
From: kernel test robot <lkp@...el.com>
To: Sudeep Holla <sudeep.holla@....com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
"Rafael J . Wysocki" <rafael@...nel.org>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
Sudeep Holla <sudeep.holla@....com>
Subject: Re: [PATCH v2] ACPI: PCC: Implement OperationRegion handler for the
PCC Type 3 subtype
Hi Sudeep,
I love your patch! Yet something to improve:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linux/master linus/master v5.16-rc8 next-20220105]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Sudeep-Holla/ACPI-PCC-Implement-OperationRegion-handler-for-the-PCC-Type-3-subtype/20220104-000003
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-randconfig-a012-20220105 (https://download.01.org/0day-ci/archive/20220106/202201060524.QF2PbOn8-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project d5b6e30ed3acad794dd0aec400e617daffc6cc3d)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/1dbcdc47eadc8c55659410fc03d067f3438a386a
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Sudeep-Holla/ACPI-PCC-Implement-OperationRegion-handler-for-the-PCC-Type-3-subtype/20220104-000003
git checkout 1dbcdc47eadc8c55659410fc03d067f3438a386a
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> drivers/acpi/acpi_pcc.c:53:3: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror,-Wimplicit-function-declaration]
return_ACPI_STATUS(AE_NO_MEMORY);
^
include/acpi/acoutput.h:398:19: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
drivers/acpi/acpi_pcc.c:53:3: note: did you mean 'acpi_irq_stats_init'?
include/acpi/acoutput.h:398:19: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/linux/acpi.h:320:6: note: 'acpi_irq_stats_init' declared here
void acpi_irq_stats_init(void);
^
>> drivers/acpi/acpi_pcc.c:53:3: error: use of undeclared identifier '_acpi_module_name'
return_ACPI_STATUS(AE_NO_MEMORY);
^
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:36: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
>> drivers/acpi/acpi_pcc.c:53:3: error: use of undeclared identifier '_COMPONENT'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:55: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:66:3: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror,-Wimplicit-function-declaration]
return_ACPI_STATUS(AE_NOT_FOUND);
^
include/acpi/acoutput.h:398:19: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
drivers/acpi/acpi_pcc.c:66:3: error: use of undeclared identifier '_acpi_module_name'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:36: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:66:3: error: use of undeclared identifier '_COMPONENT'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:55: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:75:3: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror,-Wimplicit-function-declaration]
return_ACPI_STATUS(AE_NO_MEMORY);
^
include/acpi/acoutput.h:398:19: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
drivers/acpi/acpi_pcc.c:75:3: error: use of undeclared identifier '_acpi_module_name'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:36: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:75:3: error: use of undeclared identifier '_COMPONENT'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:55: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:79:2: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror,-Wimplicit-function-declaration]
return_ACPI_STATUS(AE_OK);
^
include/acpi/acoutput.h:398:19: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
drivers/acpi/acpi_pcc.c:79:2: error: use of undeclared identifier '_acpi_module_name'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:36: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:79:2: error: use of undeclared identifier '_COMPONENT'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
include/acpi/acoutput.h:258:55: note: expanded from macro 'ACPI_DEBUG_PARAMETERS'
__LINE__, ACPI_GET_FUNCTION_NAME, _acpi_module_name, _COMPONENT
^
drivers/acpi/acpi_pcc.c:97:3: error: implicit declaration of function 'acpi_ut_status_exit' [-Werror,-Wimplicit-function-declaration]
return_ACPI_STATUS(AE_ERROR);
^
include/acpi/acoutput.h:398:19: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
drivers/acpi/acpi_pcc.c:97:3: error: use of undeclared identifier '_acpi_module_name'
include/acpi/acoutput.h:398:2: note: expanded from macro 'return_ACPI_STATUS'
ACPI_TRACE_EXIT (acpi_ut_status_exit, acpi_status, status)
^
include/acpi/acoutput.h:375:13: note: expanded from macro 'ACPI_TRACE_EXIT'
function (ACPI_DEBUG_PARAMETERS, _param); \
^
vim +/acpi_ut_status_exit +53 drivers/acpi/acpi_pcc.c
42
43 static acpi_status
44 acpi_pcc_address_space_setup(acpi_handle region_handle, u32 function,
45 void *handler_context, void **region_context)
46 {
47 struct pcc_data *data;
48 struct acpi_pcc_info *ctx = handler_context;
49 struct pcc_mbox_chan *pcc_chan;
50
51 data = kzalloc(sizeof(*data), GFP_KERNEL);
52 if (!data)
> 53 return_ACPI_STATUS(AE_NO_MEMORY);
54
55 data->cl.rx_callback = pcc_rx_callback;
56 data->cl.knows_txdone = true;
57 data->ctx.length = ctx->length;
58 data->ctx.subspace_id = ctx->subspace_id;
59 data->ctx.internal_buffer = ctx->internal_buffer;
60
61 init_completion(&data->done);
62 data->pcc_chan = pcc_mbox_request_channel(&data->cl, ctx->subspace_id);
63 if (IS_ERR(data->pcc_chan)) {
64 pr_err("Failed to find PCC channel for subspace %d\n",
65 ctx->subspace_id);
66 return_ACPI_STATUS(AE_NOT_FOUND);
67 }
68
69 pcc_chan = data->pcc_chan;
70 data->pcc_comm_addr = acpi_os_ioremap(pcc_chan->shmem_base_addr,
71 pcc_chan->shmem_size);
72 if (!data->pcc_comm_addr) {
73 pr_err("Failed to ioremap PCC comm region mem for %d\n",
74 ctx->subspace_id);
75 return_ACPI_STATUS(AE_NO_MEMORY);
76 }
77
78 *region_context = data;
79 return_ACPI_STATUS(AE_OK);
80 }
81
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists