linux-kernel - Re: [PATCH v2] scripts: sphinx-pre-install: Fix ctex support on Debian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15aa5e03-8aac-af55-badc-b905ca91f281@gmail.com>
Date:   Thu, 6 Jan 2022 11:00:08 +0900
From:   Akira Yokosawa <akiyks@...il.com>
To:     Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Akira Yokosawa <akiyks@...il.com>
Subject: Re: [PATCH v2] scripts: sphinx-pre-install: Fix ctex support on
 Debian

On Thu,  6 Jan 2022 01:41:02 +0100, Mauro Carvalho Chehab wrote:
> The name of the package with ctexhook.sty is different on
> Debian/Ubuntu.
> 
> Reported-by: Akira Yokosawa <akiyks@...il.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@...nel.org>

Tested-by: Akira Yokosawa <akiyks@...il.com>

> ---
>  scripts/sphinx-pre-install | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/scripts/sphinx-pre-install b/scripts/sphinx-pre-install
> index 46aaab414098..f126ecbb0494 100755
> --- a/scripts/sphinx-pre-install
> +++ b/scripts/sphinx-pre-install
> @@ -370,6 +370,9 @@ sub give_debian_hints()
>  	);
>  
>  	if ($pdf) {
> +		check_missing_file(["/usr/share/texlive/texmf-dist/tex/latex/ctex/ctexhook.sty"],
> +				   "texlive-lang-chinese", 2);
> +
>  		check_missing_file(["/usr/share/fonts/truetype/dejavu/DejaVuSans.ttf"],
>  				   "fonts-dejavu", 2);
>  
> -- 
> 2.33.1

So are you planing to add similar checks incrementally for the
other distros ?

There are two things I'd like to mention.

First, on Debian buster, Ubuntu Bionic, and Ubuntu Focal,
xeCJK.sty are younger then v3.8.3 and ctexhook.sty is not necessary.
As texlive-lang-chinese is a fairly large package, it would be better
not to require the unnecessary package.

The new dependency can be checked by:

    $ grep ctex `kpsewhich xeCJK.sty`

If there is no hit, no need of ctexhook.sty.

It would be nice if the check can be made conditional.
But it would not be possible to check before you have xeCJK.sty
on your system.

Hmm??

Second, on CentOS stream8, texlive-ctex is not available.
Following is the error from "dnf install":

    $ sudo dnf install texlive-ctex
    Last metadata expiration check: 0:00:35 ago on Thu Jan  6 01:43:50 2022.
    No match for argument: texlive-ctex
    Error: Unable to find a match: texlive-ctex

xeCJK.sty there is also younger then v3.8.3.

So again, if the check of ctexhook.sty could be made conditional,
we would be able to list CentOS stream8 (or RHEL 8) as capable
of "make pdfdocs".

Longer term (for CentOS stream9 or RHEL 9), we might need to ask
EPEL maintainers to add texlive-ctex.

Thoughts?

List of xeCJK.sty version:

    Debian buster   v3.7.1
    Ubuntu Bionic   v3.6.1
    Ubuntu Focal    v3.8.1
    CentOS stream8  v3.5.0

        Thanks, Akira