linux-kernel - Re: [PATCH net v3] net/smc: Reset conn->lgr when link group registration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Jan 2022 10:09:46 +0800
From:   Wen Gu <guwen@...ux.alibaba.com>
To:     Karsten Graul <kgraul@...ux.ibm.com>, dust.li@...ux.alibaba.com,
        davem@...emloft.net, kuba@...nel.org
Cc:     linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] net/smc: Reset conn->lgr when link group
 registration fails

Thanks for your suggestion.

On 2022/1/5 9:25 pm, Karsten Graul wrote:

> It might look cleaner with the following changes:
> - adopt smc_lgr_cleanup_early() to take only an lgr as parameter and remove the call to smc_conn_free()
> - change smc_conn_abort() (which is the only caller of smc_lgr_cleanup_early() right now), always
>    call smc_conn_free() and if (local_first) additionally call smc_lgr_cleanup_early()
>    (hold a local copy of the lgr for this call)
> - finally call smc_lgr_cleanup_early(lgr) from smc_conn_create()
> 
> This should be the same processing, but the smc_conn_free() is moved to smc_conn_abort() where
> it looks to be a better place for this call. And smc_lgr_cleanup_early() takes only care of an lgr.
> 

I think those are very good changes, making smc_lgr_cleanup_early() processing link group only and
more reusable.

> What do you think? Did I miss something?
I think it is better and complete. I will improve the patch and test it, then send a v4.

Thanks,
Wen Gu